dictionaries-common versions of ispell.el and flyspell.el break recent emacsen

Tested all combinations of all files:

/usr/share/emacs/site-lisp/dictionaries-common/debian-ispell.el

seems not to be needed for anything, but of the three files mentioned above this file alone does not seem to do any harm.

I hadn't spotted you hitting this on Maverick. Everything worked fine for me on Lucid but on upgrade to Maverick flyspell got broken. In the two months since the problem was reported it was not fixed. Sigh.

I tried removing the files

/usr/share/emacs/site-lisp/dictionaries-common/debian-ispell.el
/usr/share/emacs/site-lisp/dictionaries-common/flyspell.el
/usr/share/emacs/site-lisp/dictionaries-common/ispell.el

after reinstaling emacs and dictionaries-common, but flyspell still does not work. Is there a workaround, or should I do something additionally to removing those files?

I suppose you have seen the following bug in Debian:

http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=5;bug=591925

where it seems that it is explained what is going on (a function that changed in emacs that neede two arguments and now needs only one). I also tried the workaround suggested there in comment #54 but it did not work for me in Maverick.

Hi all,
       I also tried the workaround but it did not work for me. Is any there some solution for this bug? I need this feature soon because my Englich is so vad.

Thank you!

You have to remove the byte-compiled *.elc files too. Updating bug description.

After upgrading to maverick I had this ug. The fix reporte in Debian bug 591925 worked for me.

I confirm that the workaround works after removing also the byte-compiled files (*.elc) which I hadn't done in my comment #5

I also noticed this bug when upgrading to Maverick. I can also confirm that the deleting the *.el and *.elc fixes the problem.

The upstream bug http://bugs.debian.org/592720 was fixed in dictionaries-common 1.5.12 http://packages.debian.org/changelogs/pool/main/d/dictionaries-common/current/changelog

The fix for this bug is the only difference between dictionaries-common 1.5.11 (which is what Ubuntu currently ships) and 1.5.12. Debian is currently at 1.5.14.

The upstream fix is to keep these files in dictionaries-common (they are included to override the ones in emacs, for a more or less good reason) but fix the incompatibility introduced by a syntax change in upstream Emacs (alleged to have occurred in 23.2, but obviously affecting emacs23 23.1+1-4ubuntu7).

I guess this might not qualify for an SRU, but should definitely be eligible to be uploaded to -backports.

Pending on bug #660357

This patch to flyspell.el worked for me.

(NOTE you will have to recompile the elisp, as well, or the existing .elc file(s) will get used)

You can also "work around the problem" by adding this to your .emacs
(setq flyspell-issue-welcome-flag nil) ;; assumes you don't care about a welcome message when flyspell-mode is enabled

Installing Debian's 1.5.14 package from http://packages.debian.org/sid/dictionaries-common worked for me.

Their patch[1] is a little more complicated than Brian Carlson's one as it tries to take into account 2 Gnu Emacs versions and Xemacs. See http://git.debian.org/?p=dict-common/dictionaries-common.git;a=commitdiff;h=6923a768933b92c68fbd5bcaa04021c1d5c5a6e4

I confirm this package works.
Thank you Douglas!

This bug was fixed with bug #660357 for Natty, but getting a fix for Maverick would be highly valuable.

Submitted bug #666204 to request a backport for Maverick.

Updated package description in accordance with instructions at https://wiki.ubuntu.com/StableReleaseUpdates

I'm unsure whether this should be an SRU or a backport; this kind of seems to fall between the cracks. I'm trying both approaches now; apologies if I am wasting too much of everybody's time this way.

This seems like a good candidate for an SRU to me. The fix is isolated and short, which helps give this a low likelihood of regression. Some small mangling of Debian's version is necessary to fit with our version numbering scheme.

The attached debdiff should fix this for Maverick.

The patch failed to apply to 580_flyspell.el_called-interactively-p.dpatch. Please update your debdiff.

Sorry about that. Looks like I accidentally converted tabs to spaces or something.

Please try the newly attached debdiff instead.

Thanks for your work, reviewing this now. All being well, tiw ill be uploaded to maverick-proposed.

This package failed to build for me, build log attached. If you could have a look to see what the problem is, and attempt to fix it, that would be great.

I am unsubscribing ubuntu-sponsors for now. Please re-subscribe ubuntu-sponsors when you have a new debdiff ready for review.

Thanks again for your work.

Seems I may have a broken chroot. Unfortunately I don't have time to look into it at the moment. Marking as new for another pilot/sponsor to pick up. Sorry about not being able to action this bug any further.

Bug is still active on Maverick since it is still at "dictionaries-common 1.5.11ubuntu1".

WORKAROUND: install the Debian package http://packages.debian.org/sid/dictionaries-common

I've kubuntu natty fresh installed. The bug is come back.
How I can solve the problem?

Hi,
    Mmmm... I have fresh installation of Ubuntu Natty, I don't have
this bug. Are Ubuntu or Kubuntu different in something?

On Tue, Jun 7, 2011 at 1:01 PM, 3ntix <email address hidden> wrote:
> I've kubuntu natty fresh installed. The bug is come back.
> How I can solve the problem?
>
> --
> You received this bug notification because you are a direct subscriber
> of the bug.
> https://bugs.launchpad.net/bugs/619015
>
> Title:
>  dictionaries-common versions of ispell.el and flyspell.el break recent
>  emacsen
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/ubuntu/+source/dictionaries-common/+bug/619015/+subscribe
>

--
Paul Leger

Natty has 1.9.3 and it should be the same whether you use Kubuntu or Xubuntu.

3ntix: Please file a separate bug report, you are probably seeing a different problem.