Network traffic plugin doesn't take into account integer overflows
Bug #615371 reported by
Andreas Hasenack
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Landscape Client |
Fix Released
|
High
|
Thomas Herve | ||
landscape-client (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Jaunty |
Fix Released
|
Undecided
|
Unassigned | ||
Karmic |
Fix Released
|
Undecided
|
Unassigned | ||
Lucid |
Fix Released
|
Undecided
|
Unassigned | ||
Maverick |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
The client sends the network traffic information as deltas, and sometimes these values are negative which indicates the data wrapped around. The client should take this into account.
Related branches
lp:~therve/landscape-client/network-plugin-reboot
- Kevin McDermott (community): Approve
- Jamu Kakar (community): Approve
-
Diff: 177 lines (+91/-8)3 files modifiedlandscape/lib/network.py (+1/-1)
landscape/monitor/networkactivity.py (+26/-5)
landscape/monitor/tests/test_networkactivity.py (+64/-2)
Changed in landscape-client: | |
assignee: | nobody → Thomas Herve (therve) |
Changed in landscape-client: | |
status: | New → In Progress |
Changed in landscape-client: | |
status: | In Progress → Fix Committed |
tags: | added: needs-testing |
Changed in landscape-client: | |
milestone: | 1.5.5 → 1.5.5.1 |
tags: | removed: needs-testing |
Changed in landscape-client (Ubuntu Jaunty): | |
status: | New → Fix Committed |
tags: |
added: verification-done removed: verification-needed |
Changed in landscape-client: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I think it's more problematic than that: a simple restart will make the value wrap around, because we're comparing the /proc/net/dev content before and after a restart.