Please convert winbind init script to upstart.

Bug #612958 reported by Chuck Short
54
This bug affects 9 people
Affects Status Importance Assigned to Milestone
samba (Ubuntu)
Fix Released
Wishlist
James Page
Quantal
Fix Released
Wishlist
James Page

Bug Description

Binary package hint: samba

Please convert the winbind init script to upstart. This is part of the server-maverick-upstart-conversion specification. I have attached a debdiff for your review.

If you have any questions please let me know.

chuck

Related branches

Revision history for this message
Chuck Short (zulcss) wrote :
Mathias Gug (mathiaz)
Changed in samba (Ubuntu):
importance: Undecided → Wishlist
Revision history for this message
Colin Watson (cjwatson) wrote :

--upstart-only is incorrect here - there's previously been an init script and we need to migrate from it. Please make sure to test this.

Other than that this looks fine to me.

Chuck Short (zulcss)
Changed in samba (Ubuntu):
status: New → Confirmed
Revision history for this message
David Weber (wb-munzinger) wrote :

Attached upstart script works fine for me since a few months. The long delay before you can login to an AD after boot is also gone.

Any chance to see this in precise?

Revision history for this message
Betibeteka Beranduetxea (artxitatel) wrote :

Yeah, I will be happy if something like this makes in precise.

On my systems winbind tries to connect before there is any connection up. This is specially true if connection is via wlan, even if network manager's sets connection as system-wide and available to all users.

On a 11.04 system, winbind puts a message in /var/log/syslog 4 seconds before wlan0 is connected. Solved by adding "sleep 10" at first lines of /etc/init.d/winbind

And I think the long delay before you can log in is caused by gdm's starting too fast, as this blog explains: http://davidmburke.com/2010/09/16/linux-and-active-directory-round-2/

Both problems will be solved by making winbind an upstart job, and I think it's a shame that it still remains untouched.

It's true that ligthdm.conf has solved this problem at least in 12.04, (I have not tested 11.10) but still we need some way to make sure there is a network connection up and running before winbind's start.

Revision history for this message
Zbyszek Wieczorek (zbyszek-wieczorek) wrote :

Converting winbind init.d to upstart as mentioned above works for me and now I can login with winbind to active directory

James Page (james-page)
Changed in samba (Ubuntu Quantal):
milestone: none → quantal-alpha-2
assignee: nobody → James Page (james-page)
James Page (james-page)
Changed in samba (Ubuntu Quantal):
status: Confirmed → In Progress
James Page (james-page)
Changed in samba (Ubuntu Quantal):
milestone: quantal-alpha-2 → quantal-alpha-3
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (3.4 KiB)

This bug was fixed in the package samba - 2:3.6.6-2ubuntu1

---------------
samba (2:3.6.6-2ubuntu1) quantal; urgency=low

  * Merge from Debian unstable; remaining changes:
    + debian/patches/VERSION.patch:
      - set SAMBA_VERSION_SUFFIX to Ubuntu.
    + debian/smb.conf:
      - add "(Samba, Ubuntu)" to server string.
      - comment out the default [homes] share, and add a comment about
        "valid users = %S" to show users how to restrict access to
        \\server\username to only username.
    + debian/samba-common.config:
      - Do not change priority to high if dhclient3 is installed.
      - Use priority medium instead of high for the workgroup question.
    + debian/control:
      - Don't build against or suggest ctdb.
      - Add dependency on samba-common-bin to samba.
    + Add ufw integration:
      - Created debian/samba.ufw.profile
      - debian/rules, debian/samba.install: install profile.
      - debian/control: have samba suggest ufw.
    + Add apport hook:
      - Created debian/source_samba.py.
      - debian/rules, debian/samba-common-bin.install: install hook.
    + Switch to upstart:
      - Added debian/samba.{nmbd,smbd}.upstart.
      - debian/samba.logrotate, debian/samba-common.dhcp, debian/samba.if-up:
        Make upstart compatible.
  * Dropped:
    + d/patches/lp_970679_fix-large-groups.patch: included in 3.6.6 release.
  * d/winbind.upstart: converted winbind init script to upstart (LP: #612958).
  * d/rules: Drop explicit configuration options for ctdb.

samba (2:3.6.6-2) unstable; urgency=low

  * Restore the DHCP hook.

samba (2:3.6.6-1) unstable; urgency=low

  [ Ivo De Decker ]
  * Only enable swat in inetd.conf on first install. Closes: #658245
  * Minor lintian fixes.
  * Remove DHCP hook. Closes: #652942, #629406, #649100
  * Don't reload smbd when running from inetd. Closes: #678741
  * Don't start smbd when guest account doesn't exist. Closes: #653382
  * Only export public symbols in libsmbclient and libwbclient.

  [ Christian Perrier ]
  * New upstream version

samba (2:3.6.5-7) unstable; urgency=low

  * Allow installing smbclient package together with newer versions of
    samba4-clients, which no longer ship the smbclient and nmblookup
    binaries.

samba (2:3.6.5-6) unstable; urgency=high

  [ Ivo De Decker ]
  * Update symbols file for linux-only symbols in libsmbclient. This should
    fix the FTBFS on kfreebsd and hurd. Closes: #676170
  * Enable ctdb for non-linux archs.
  * Remove old if-up script during upgrade.

samba (2:3.6.5-5) unstable; urgency=low

  [ Christian Perrier ]
  * Make libpam-winbind depend on libnss-winbind.

  [ Ivo De Decker ]
  * Update symbols file for libsmbclient and libwbclient0
  * Add lintian overrides for examples in samba-doc
  * libpam-winbind: change Depends on libnss-winbind to Recommends
  * libnss-winbind: Suggests libpam-winbind
  * Update package description for winbind, libpam-winbind and libnss-winbind
    to better reflect their content
  * Backport vfs_shadow_copy2 from master, to allow shadow copy to work
    without wide links

  [ Luk Claes ]
  * Ship wbclient.pc file in multiarch safe directory (Closes: #674215).

  [ Sam Morris ]
  * ...

Read more...

Changed in samba (Ubuntu Quantal):
status: In Progress → Fix Released
Revision history for this message
roelof van der kleij (r-g-van-der-kleij) wrote :

Any chance of a backport to 12.04 LTS?

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.