Landscape Client

Landscape manager fails to acquire lock for its socket

Bug #607747 reported by Free Ekanayaka on 2010-07-20

140

This bug affects 10 people

	Status	Importance	Assigned to	Milestone
Landscape Client	Fix Released	High	Free Ekanayaka	Landscape Client 1.5.5.1
landscape-client (Ubuntu)	Fix Released	Undecided	Unassigned
Jaunty	Fix Released	Undecided	Unassigned
Karmic	Fix Released	Undecided	Unassigned
Lucid	Fix Released	Undecided	Unassigned
Maverick	Fix Released	Undecided	Unassigned

Bug Description

It happened on Barry's Maverick installation.

Tags:

Related branches

lp:~free.ekanayaka/landscape-client/socket-locks-fix

Merged into lp:~landscape/landscape-client/trunk

Gavin Panella (community): Approve on 2010-08-12

Björn Tillenius (community): Approve on 2010-08-12

lp:~ahasenack/landscape-client/landscape-client-1.5.5.1-0ubuntu0.10.04.0

lp:~ahasenack/landscape-client/landscape-client-1.5.5.1-0ubuntu0.9.04.0

lp:~ahasenack/landscape-client/landscape-client-1.5.5.1-0ubuntu0.9.10.0

Free Ekanayaka (free.ekanayaka) on 2010-07-20

Changed in landscape-client:
assignee:	nobody → Free Ekanayaka (free.ekanayaka)

Revision history for this message

Barry Warsaw (barry) wrote on 2010-07-20:

_usr_bin_landscape-manager.0.crash Edit (15.6 KiB, text/plain)

Revision history for this message

Andreas Hasenack (ahasenack) wrote on 2010-08-10:

Reproduced and debugged. The issue happens when a stale lock file exists in /var/lib/landscape/client/sockets and its stale PID points to an existing process that is still running.

Free Ekanayaka (free.ekanayaka) on 2010-08-10

Changed in landscape-client:
importance:	Undecided → High
milestone:	none → 1.5.5
status:	New → In Progress

Free Ekanayaka (free.ekanayaka) on 2010-08-12

Changed in landscape-client:
status:	In Progress → Fix Committed

Andreas Hasenack (ahasenack) on 2010-08-31

tags:

added: needs-testing

Revision history for this message

Andreas Hasenack (ahasenack) wrote on 2010-09-10:

Confirmed fixed in the maverick package.

Revision history for this message

Andreas Hasenack (ahasenack) wrote on 2010-09-14:

Confirmed fixed in the Lucid and Karmic packages.

Revision history for this message

Colin Watson (cjwatson) wrote on 2010-09-16:

landscape-client (1.5.5-0ubuntu0.10.10.0) maverick; urgency=low

* New upstream version (LP: #633468)

- The --help command line option can now be used without being
root (LP: #613256).

    - The client Unix sockets and symlinks are now cleaned up at shutdown.
      Without this cleaning, the client could refuse to start because of a PID
      collision (LP: #607747).

    - The network traffic plugin didn't use to take into account integer
      overflows. This would cause the plugin to send negative values
      sometimes (LP: #615371).

- If a payload had many user activities in it, only the last one would be
carried out (LP: #617624).

- The Eucalyptus plugin was not enabled by default, which means the Cloud
Topology feature of Landscape was not available (LP: #614493).

-- Andreas Hasenack <email address hidden> Wed, 08 Sep 2010 15:34:09 -0400

Changed in landscape-client (Ubuntu):
status:	New → Fix Released

Andreas Hasenack (ahasenack) on 2010-09-17

Changed in landscape-client:
milestone:	1.5.5 → 1.5.5.1

Revision history for this message

solarisfire (sg-solarisfire) wrote on 2010-09-20:

So how would one go about getting this fix in Lucid?

Revision history for this message

Andreas Hasenack (ahasenack) wrote on 2010-09-20:

It will be in lucid-proposed shortly, and a week after that in lucid-updates. We postponed it to 1.5.5.1 because we want to get a fix for bug #641264 in as well.

Revision history for this message

Andreas Hasenack (ahasenack) wrote on 2010-09-20:

In the meantime, if you are in a situation where landscape-client gets restarted frequently, and are thus more susceptible to this bug, I suggest to clean up the lock files in the "stop" target of the landscape-client initscript. Something like "rm -f /var/lib/landscape/client/sockets/*lock".

Revision history for this message

Andreas Hasenack (ahasenack) wrote on 2010-09-20:

The nomination for Maverick can be dropped, as it was fixed in 1.5.5.

Changed in landscape-client (Ubuntu):
status:	Fix Released → Fix Committed

Andreas Hasenack (ahasenack) on 2010-09-27

tags:

removed: needs-testing

Revision history for this message

Martin Pitt (pitti) wrote on 2010-09-28:

#10

I suppose these bugs are fixed in 1.5.5.1, which is in maverick.

Changed in landscape-client (Ubuntu Maverick):
status:	Fix Committed → Fix Released
Changed in landscape-client (Ubuntu Lucid):
status:	New → Fix Committed
tags:	added: verification-needed

Revision history for this message

Martin Pitt (pitti) wrote on 2010-09-28: Please test proposed package

#11

Accepted landscape-client into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in landscape-client (Ubuntu Karmic):
status:	New → Fix Committed

Revision history for this message

Martin Pitt (pitti) wrote on 2010-09-28:

#12

Accepted landscape-client into karmic-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Andreas Hasenack (ahasenack) on 2010-09-29

Changed in landscape-client (Ubuntu Jaunty):
status:	New → Fix Committed

Revision history for this message

Andreas Hasenack (ahasenack) wrote on 2010-10-01:

#13

Confirmed fixed in 1.5.5.1-0ubuntu0.9.10.0 from proposed repository for karmic.

Revision history for this message

Andreas Hasenack (ahasenack) wrote on 2010-10-01:

#14

Confirmed fixed in 1.5.5.1-0ubuntu0.10.04.0 from the lucid proposed repository.

Revision history for this message

Andreas Hasenack (ahasenack) wrote on 2010-10-01:

#15

Confirmed fixed in 1.5.5.1-0ubuntu0.9.04.0 from the jaunty proposed repository.

Jean-Baptiste Lallement (jibel) on 2010-10-01

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-10-05:

#16

This bug was fixed in the package landscape-client - 1.5.5.1-0ubuntu0.10.04.0

---------------
landscape-client (1.5.5.1-0ubuntu0.10.04.0) lucid-proposed; urgency=low

  * The client network plugin would send erroneous data if a network
    interface was removed (and its kernel module removed as well) and
    then readded (LP: #641264).

landscape-client (1.5.5-0ubuntu0.10.04.0) lucid-proposed; urgency=low

* New upstream version (LP: #633468)

- The --help command line option can now be used without being
root (LP: #613256).

    - The client Unix sockets and symlinks are now cleaned up at shutdown.
      Without this cleaning, the client could refuse to start because of a PID
      collision (LP: #607747).

    - The network traffic plugin didn't use to take into account integer
      overflows. This would cause the plugin to send negative values
      sometimes (LP: #615371).

- If a payload had many user activities in it, only the last one would be
carried out (LP: #617624).

- The Eucalyptus plugin was not enabled by default, which means the Cloud
Topology feature of Landscape was not available (LP: #614493).
-- Andreas Hasenack <email address hidden> Mon, 20 Sep 2010 13:52:49 -0300

Changed in landscape-client (Ubuntu Lucid):
status:	Fix Committed → Fix Released

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-10-05:

#17

This bug was fixed in the package landscape-client - 1.5.5.1-0ubuntu0.9.10.0

---------------
landscape-client (1.5.5.1-0ubuntu0.9.10.0) karmic-proposed; urgency=low

  * The client network plugin would send erroneous data if a network
    interface was removed (and its kernel module removed as well) and
    then readded (LP: #641264).

landscape-client (1.5.5-0ubuntu0.9.10.0) karmic-proposed; urgency=low

* New upstream version (LP: #633468)

- The --help command line option can now be used without being
root (LP: #613256).

    - The client Unix sockets and symlinks are now cleaned up at shutdown.
      Without this cleaning, the client could refuse to start because of a PID
      collision (LP: #607747).

    - The network traffic plugin didn't use to take into account integer
      overflows. This would cause the plugin to send negative values
      sometimes (LP: #615371).

- If a payload had many user activities in it, only the last one would be
carried out (LP: #617624).

Changed in landscape-client (Ubuntu Karmic):
status:	Fix Committed → Fix Released

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-10-05:

#18

This bug was fixed in the package landscape-client - 1.5.5.1-0ubuntu0.9.04.0

---------------
landscape-client (1.5.5.1-0ubuntu0.9.04.0) jaunty-proposed; urgency=low

  * The client network plugin would send erroneous data if a network
    interface was removed (and its kernel module removed as well) and
    then readded (LP: #641264).

landscape-client (1.5.5-0ubuntu0.9.04.0) jaunty-proposed; urgency=low

* New upstream version (LP: #633468)

- The --help command line option can now be used without being
root (LP: #613256).

    - The client Unix sockets and symlinks are now cleaned up at shutdown.
      Without this cleaning, the client could refuse to start because of a PID
      collision (LP: #607747).

    - The network traffic plugin didn't use to take into account integer
      overflows. This would cause the plugin to send negative values
      sometimes (LP: #615371).

- If a payload had many user activities in it, only the last one would be
carried out (LP: #617624).