oops should record the short traceback that caused each query?

Bug #606959 reported by Martin Pool
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
Unassigned

Bug Description

istm that it would help with debugging some problems like <https://bugs.edge.launchpad.net/launchpad-foundations/+bug/424671> if we logged the single-line traceback (just class.method:class.method:...) that caused each query to run.

Revision history for this message
Martin Pool (mbp) wrote :

This could probably be done in connection_raw_execute or the like.

Revision history for this message
Gary Poster (gary) wrote :

I'd want to do some performance tests before pursuing this.

Changed in launchpad-foundations:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Martin Pool (mbp) wrote : Re: [Bug 606959] Re: oops should record the short traceback that caused each query?

On 20 July 2010 02:35, Gary Poster <email address hidden> wrote:
> I'd want to do some performance tests before pursuing this.

Yes, there's definitely some risk there. Specifically if we're doing
an unreasonably large number of queries this will make us more likely
to oops; if we're doing a reasonably small number it will be fine.

Robert suggests we could turn this only only on non-lpnet servers.

timeit shows that traceback.format_stack takes about 0.24ms per call
(on a fairly short stack, so it may get longer.) So maybe it's
another 1ms per query we do, whether the page ultimately ends up
oopsing or not. jam says the fastest query is about 1ms but the
slowest ones are obviously

--
Martin

Revision history for this message
Robert Collins (lifeless) wrote :

Once we get our peak action counts down to (say) 200 or so I'd be interested in pursuing this; right now we have many things up in the thousands, and this would add seconds to those pages.

William Grant (wgrant)
Changed in launchpad:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.