EAN code validation fails

please try with attached chricar_product_gtin

IMHO it's a bug in the server as the constraint in product.py must be disabled manually , after doing so the constraint check works.

product/product.py
#_constraints = [(_check_ean_key, 'Error: Invalid ean code', ['ean13'])]

you should get an different message entering code like
"Error: Invalid Bar Code Number"

please can someone with more rights change the titel of this bug
"_constraints are not (always ?) replaced ..."

Why is this code not simply taken into the main product/product.py.

This is so universal, I cannot believe that there are many people who can get along with ean-13 only.

very good question ;-)
IIRC the default installation takes 12 digits and calculates the checkdigit (13) - so it was not even suitable for UPC..

Hello Ferdinand,Gerhard,

      I have checked the scenario for EAN. And I agree with you guys that EAN should be in all varieties. So I have made few changes for that and have attached a solution for that. Would you please check it and notify us? Thanks a lot for pointing towards the issue. It will improve the functionality for products using different EANs.

Thanks.

I tried the patch but it still fails. (applied to 5.0.12)
Here is an example of a valid ean code used on a daily basis.
16001009005806

@Anup
Using my module I can enter and save a product with all the number given here as an example - IMHO the formula given in my module is correct - do not have time to check if you implemented it completely

Hello Gerhard,

   I have checked the ean14 example code and have made few modifications in the existing patch and made a refined solution. Would you please check it and notify us?

Thanks,

Hello!

I just discovered another instance of ean check here

product/product.py
class product_packaging(osv.osv):

as well as in res/parnter/partner.py

IMHO we should have only ONE check procedure which is called from the other modules

ean in class product_packaging
* is not checked for valid entry
* the content of ean is displayed in the field "Packaging" (because of _recname ='ean')

if the ean is empty - which is a valid and necessary option "False" is displayed - not useable.

IMHO we need a name_get which returns the ean or name (Description)

@Anup - can you do this ?

Hello Gerhard,

I have Fixed for EAN8,EAN13 and EAN14 Code validation check below Branch

It has been fixed in lp:~openerp-dev/openobject-addons/ron-dev-addons2
Revision ID: <email address hidden>
Revision num: 5059.

and also Fix validation field "ean" in product_packaging on below Revision ID

It has been fixed in lp:~openerp-dev/openobject-addons/ron-dev-addons2
Revision ID: <email address hidden>
Revision num: 5060.

It will be available in trunk soon,

I do not know if this ever arrived in trunk
I attach a module fixing the issue for v6

please see
extra-trunk/chricar_product_gtin

On Sunday 09 January 2011, you wrote:
> please see
> extra-trunk/chricar_product_gtin
>
> ** Attachment removed: "chricar_product_gtin.tar"
>
> https://bugs.launchpad.net/openobject-addons/+bug/606325/+attachment/17875
> 62/+files/chricar_product_gtin.tar

For some reason, the tar file is not accessible. Can you please check again or
provide us a new path for that module?

I'm interested to see how you redefine the _constraints[] in that module.

Meanwhile I manage to save it to extra-trunk/chricar_product_gtin so I removed the tar to avoid duplicates

please see
 extra-trunk/chricar_product_gtin (comment 14)

please could you also check the complete construct

in product/product.py the check_ean is not part of product_product() any more
Question how to replace it?

BTW IMHO htis should be standard, beccause EAN 13 is used in Europe and UPC (12) is used in USA - hence many people will need this extension.

works now with V6

Hello everyone

I want to know, If I change the constraint in those two places, I can still reading a bar code example UPC-!2 but without validation?. I needed because all the products have UPC-A or UPC-E 8 digits.

Thanks