"Crop to selection" can enlarge image

I guess the issue here is to ensure the selection doesn't go outside the canvas. I cannot reproduce that, do you remember how you got it to do that?

I have a similar problem with Pinta 0.5.
If I start a selection outside the image, then crop or copy it, I get a larger image with trasparency where there isn't image.

The bug is in the selection and not with the function "Crop to selection". I get the same problem if I just copy and paste the selection somewhere.

I get the problem only with rectangular select and ellipse select

Fixed in https://github.com/jpobst/Pinta/commit/6b84704d7a91a620c3b56f5ebbea684436c5125c.

Thanks for the report!

I have installed Pinta 0.7 on Windows XP sp3 and I can reproduce the problem in comment 3:
1. Create new image 100x100 pixels.
2. Select Rectange Select tool from Tools.
3. Start selecting the image outside of the canvas (in my case at left-top site but outside of the canvas).
4. Canvas is market with selection (see left site of attached picture).
5. Click on Crop to Selection button from toolbar.
The image is cropped but at the right site and bottom there is transparent area displayed.

easy fix in selectTool.cs
iin OnMouseDown
- shape_origin = point;
+ // Selection is around the pixel selection so add 1 pixel
+ double x = Utility.Clamp (point.X, 0, doc.ImageSize.Width);
+ double y = Utility.Clamp (point.Y, 0, doc.ImageSize.Height);
+ shape_origin = new PointD (x, y);

OnMouseMove

- double x = Utility.Clamp (point.X, 0, doc.ImageSize.Width - 1);
- double y = Utility.Clamp (point.Y, 0, doc.ImageSize.Height - 1);
+ double x = Utility.Clamp (point.X, 0, doc.ImageSize.Width);
+ double y = Utility.Clamp (point.Y, 0, doc.ImageSize.Height);

because size an origin was miss clamped...

my patch was not right. But I have a new one. I will send a pull request soon.

Committed in https://github.com/jpobst/Pinta/commit/49f9bbc2833787c35e41b070950f29317cb40957.

Thanks for the test case and patch!

I have installed Pinta 0.8 on Windows xp sp3 and I have tested the case from comment 4 and now the problem is solved.