private team can't review merge proposals
Bug #604831 reported by
Monty Taylor
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Ian Booth | ||
Bug Description
Attempting to submit a merge proposal to a branch owned by/managed by a private team results in the message:
"A private team is not allowed"
Additionallly, since this is in the additional info section, there is simply an error message at the top of the screen that says "There is 1 error." but then the additional info section is not expanded, so it's not immediately apparent what the problem is.
I care less about that, and more about being able to use merge props.
Related branches
lp:~wallyworld/launchpad/private-team-mp-604831
- Curtis Hovey (community): Approve (code)
-
Diff: 374 lines (+153/-30)10 files modifiedlib/canonical/launchpad/security.py (+14/-3)
lib/lp/code/browser/branchmergeproposal.py (+2/-1)
lib/lp/code/browser/tests/test_branch.py (+39/-2)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+46/-1)
lib/lp/code/interfaces/branchmergeproposal.py (+2/-1)
lib/lp/code/interfaces/codereviewvote.py (+5/-2)
lib/lp/code/model/branch.py (+1/-1)
lib/lp/code/model/branchmergeproposal.py (+2/-1)
lib/lp/registry/doc/private-team-visibility.txt (+24/-0)
lib/lp/registry/interfaces/person.py (+18/-18)
lp:~wallyworld/launchpad/protect-inTeam-against-misuse
- Ian Booth (community): Approve (code)
| affects: | launchpad → launchpad-code |
| Changed in launchpad-code: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
| tags: | added: code-review privacy |
| tags: | added: disclosure teams |
| Changed in launchpad: | |
| importance: | Medium → Low |
| Changed in launchpad: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Ian Booth (wallyworld) |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r14530 <http://