connman should use upstart

Bug #600499 reported by Kalle Valo
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Connection Manager
Fix Released
Undecided
Kalle Valo
connman (Ubuntu)
Fix Released
Undecided
Kalle Valo

Bug Description

connman should use upstart. One obvious benefit is that connman will be restarted everytime it crashes.

Related branches

Kalle Valo (kvalo)
Changed in connman:
status: New → In Progress
assignee: nobody → Kalle Valo (kvalo)
Revision history for this message
Kalle Valo (kvalo) wrote :

Here's a patch which adds upstart support to connman.

Kalle Valo (kvalo)
Changed in connman (Ubuntu):
status: New → In Progress
assignee: nobody → Kalle Valo (kvalo)
Revision history for this message
Kalle Valo (kvalo) wrote :

v2 of my patch. Based on comments received privately:

o dbus is already started on local filesystems, "start on started dbus"
   is sufficient
o removed /etc/default/connman altogether because upstart scripts should not use that file. this is an inconvenience for the users, but didn't find a proper solution to this.
o checked that fork works properly and upstart has correct pid

Revision history for this message
Chris Coulson (chrisccoulson) wrote :

Thanks for the patch. Just a couple of comments though:

@@ -28,7 +28,7 @@
   --enable-ofono \
                 $(NULL)

-DEB_DH_INSTALLINIT_ARGS := --onlyscripts -- start 28 2 3 4 5 .
+DEB_DH_INSTALLINIT_ARGS :=

 DEB_DH_MAKESHLIBS_ARGS_ALL := -X/usr/lib/connman/

I think we can just get rid of this line entirely

+case "$1" in
+install|upgrade)
+ if dpkg --compare-versions "$2" le "0.55-0ubuntu2"; then
+ rm_conffile mypackage "/etc/default/connman"
+ fi
+esac

Small copy/paste error - the "mypackage" should say "connman".

I'll fix those before I upload though

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package connman - 0.55-0ubuntu3

---------------
connman (0.55-0ubuntu3) maverick; urgency=low

  [ Kalle Valo <email address hidden> ]
  * Compile all plugins builtin. Otherwise we don't get debug messages from
    plugins (LP: #628135)
    - update debian/rules
    - update debian/connman.install
  * Connman should use upstart (LP: #600499)
    - remove debian/connman.default
    - update debian/connman.install
    - add debian/connman.presinst
    - add debian/connman.upstart
    - update debian/rules
  * Add Apport support (LP: #600498)
    - update debian/connman.install
    - add debian/source_connman.py
    - add debian/connman-crashdb.conf

  [ Chris Coulson <email address hidden> ]
  * Fix script-in-etc-init.d-not-registered-via-update-rc.d warning
    triggered by shipping the symlink to the upstart job
    - add debian/connman.lintian-overrides
 -- Kalle Valo <email address hidden> Thu, 02 Sep 2010 16:50:03 +0100

Changed in connman (Ubuntu):
status: In Progress → Fix Released
Kalle Valo (kvalo)
Changed in connman:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.