Launchpad itself

makeSourcePackageRecipeBuildJob creates an arch-agnostic BuildQueue

Bug #598397 reported by William Grant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Low
William Grant

Bug Description

factory.makeSourcePackageRecipeBuildJob creates the BuildQueue manually, rather than using SourcePackageRecipeBuild.queueBuild(). While doing so, it fails to set the processor. This results in an arch-agnostic build, which real SPRBs are not.

Related branches

lp:~wgrant/launchpad/no-mSPRBJ
Steve Kowalik (community): Approve (code)
Diff: 472 lines (+86/-77)
10 files modified
lib/lp/buildmaster/doc/builder.txt (+7/-15)
lib/lp/buildmaster/tests/test_builder.py (+16/-3)
lib/lp/buildmaster/tests/test_buildqueue.py (+5/-4)
lib/lp/buildmaster/tests/test_queuedepth.py (+36/-15)
lib/lp/code/browser/tests/test_sourcepackagerecipe.py (+9/-7)
lib/lp/code/browser/tests/test_sourcepackagerecipebuild.py (+5/-5)
lib/lp/code/model/tests/test_recipebuilder.py (+5/-4)
lib/lp/code/model/tests/test_sourcepackagerecipe.py (+2/-4)
lib/lp/soyuz/browser/tests/test_builder.py (+1/-1)
lib/lp/testing/factory.py (+0/-19)
Aaron Bentley (abentley)
Changed in launchpad-code:
status: New → Triaged
importance: Undecided → Medium
Aaron Bentley (abentley)
tags: added: recipe
Revision history for this message
Paul Hummer (rockstar) wrote :

I might as well fix this while I'm fixing bug #602333

Changed in launchpad-code:
status: Triaged → In Progress
assignee: nobody → Paul Hummer (rockstar)
milestone: none → 10.07
Curtis Hovey (sinzui)
Changed in launchpad-code:
milestone: 10.07 → 10.08
Revision history for this message
Paul Hummer (rockstar) wrote :

This bug says there is a branch that's merged that has these changes. That's a lie. This bug is a lot more complicated than I thought. We have to rethink the way we're using the factory to create recipe builds. I would say that this isn't currently "In Progress" even though I have a branch with it. I don't think it's a good use of my time fixing this bug right now (but I can get back to it as soon as recipe bugs stop multiplying like cockroaches).

Changed in launchpad-code:
status: In Progress → Triaged
assignee: Paul Hummer (rockstar) → nobody
milestone: 10.08 → none
Robert Collins (lifeless)
Changed in launchpad:
importance: Medium → Low
William Grant (wgrant)
Changed in launchpad:
assignee: nobody → William Grant (wgrant)
status: Triaged → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r16828 (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/16828) by a commit, but not testable.

tags: added: qa-untestable
Changed in launchpad:
status: In Progress → Fix Committed
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.