Weather applet using weather underground shows weird minimum temperature

Bug #597670 reported by Ward Muylaert
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Docky
Fix Released
Low
Robert Dyer
docky (Ubuntu)
Fix Released
Undecided
Unassigned
Lucid
Fix Released
Undecided
Unassigned

Bug Description

When using Weather Underground in the weather applet, I get an odd ( = wrong) mention as (what I assume to be) the dew point.

Example:
Currently the weather applet indicates (on hovering over)
---> Clear 22C (-6C) Brussels
It's the -6C that confuses me and seems... wrong.
Upon inspection of that location (Brussels, Belgium) on the wunderground.com, I get
 22 °C
Clear
Humidity: 46%
Dew Point: 10 °C
Wind: 7 km/h / 2.1 m/s from the NNW
Pressure: 1023 hPa (Steady)
Visibility: -
Elevation: 58 m
------

If it isn't the dew point, then mentioning it like that in the hover seems confusing and anti-intuitive (to my intuition anyway).
If it is the dew point, then it's giving the wrong temperature.

Revision history for this message
Robert Dyer (psybers) wrote :

Not the dew point. It is the 'feels like' temperature (wind chill / heat index).

Changed in docky:
status: New → Invalid
Revision history for this message
Ward Muylaert (ward-muylaert) wrote :

There is something wrong with it though, feels like cannot be -6C at 22C. At the moment it is -4C at 25C.
A quick check tells me that (values rounded down) 22F = -6C and 25F = -4C. I'm not the biggest believer of a coincidence like that, so I inspected http://api.wunderground.com/auto/wui/geo/WXCurrentObXML/index.xml?query=Brussels,%20Belgium and noticed it didn't mention those values (well, it did, it says NA).

Now here's what I *think* goes wrong:
First, Temp is set @ http://bazaar.launchpad.net/~docky-core/docky/trunk/annotate/head:/StandardPlugins/Weather/src/Sources/WunderWeatherSource.cs#L189 , this is done in F.
Now FeelsLike tries to get set, it fails the checks for "NA" and thus executes:
FeelsLike = Temp; ( http://bazaar.launchpad.net/~docky-core/docky/trunk/annotate/head:/StandardPlugins/Weather/src/Sources/WunderWeatherSource.cs#L205 )
That's where it goes wrong, Temp's get is called and returns it in Celcius as per http://bazaar.launchpad.net/~docky-core/docky/trunk/annotate/head:/StandardPlugins/Weather/src/Sources/AbstractWeatherSource.cs#L84
So the value stored in FeelsLike is in C.
Now when FeelsLike's get is called, it will do the UseMetric check and call ConvertFtoC -again-, but FeelsLike value already was in C! So you end up with a weird negative value while it's the warmest day in weeks :)

Hope that made sense, I've never programmed in C# so I might have missed something.

Revision history for this message
Robert Dyer (psybers) wrote :

Yes sorry, I am highly sleep deprived lately so I did not read the actual numbers you posted, just assumed you were confused about why it gave 2 temps.

Changed in docky:
status: Invalid → Confirmed
importance: Undecided → Low
assignee: nobody → Robert Dyer (psybers)
Revision history for this message
Robert Dyer (psybers) wrote :

Fixed in rev 1519.

Changed in docky:
status: Confirmed → Fix Committed
milestone: none → 2.0.5
Changed in docky:
status: Fix Committed → Fix Released
summary: - Weather applet using weather underground shows weird minimum temperature
+ debdiff which fixes this is attached to bug #579049
summary: - debdiff which fixes this is attached to bug #579049
+ Weather applet using weather underground shows weird minimum temperature
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

debdiff which fixes this is attached to bug #579049

Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (4.1 KiB)

This bug was fixed in the package docky - 2.0.5-1

---------------
docky (2.0.5-1) unstable; urgency=low

  * New upstream release 2.0.5 "Be proud of your dock",
    changes include:
    + remove --debug flag from launcher for lower memory usage
    + update the about dialog credits to list documenters and make translation
      tab easier to read
    + change url in about dialog to the launchpad project page
    + Window-Matching
      - fix for applications commandline
      - properly match qt creator (LP: #594814)
      - prefer local over global launchers (LP: #588073) (LP: #592841)
      - match prefix for gksudo (LP: #516433)
      - fix nautilus items showing active indicator when desktop
        is focused (LP: #487113)
      - fix matching wine apps that use a prefixed launcher (LP: #596092)
    + Memory Leaks
      - dispose of calendar painter when the clock item is disposed
      - fix leak in AutoHideManager
      - several fixes using Cairo.Context.Target and Pango.Layout
      - fix leak in PagingPainters
      - fix leak in recursive file-deletion
      - fix leaking SeparatorItems, WnckDockItems
      - fix leaks with FileEmblems
      - fix Pixbuf related leaks
      - fix some leaks regarding FileMonitors
      - fix leaks regarding Tiles and AbtractTileObjects
      - fix leaking Glib.FileAdapter caused by unreferenced Action in
        FileDockItem
    + Handle invalid desktopfile entry and UriFormatException in
      FileApplicationProvider (LP: #595921)
    + fix potential crash for invalid HelperMetadata
    + handle drops correctly
    + fix handling of Helpers in HelperService
    + make the sliders in preferences behave better
    + fix drawing of rotated items
    + fix HoveredItem click-position
    + avoids fatal errors on console when loading embedded icons when no
      height or width is specified and when dock items have a null Icon
    + fix icon theme change not refreshing the dock icons (LP: #590205)
    + fix SVG rendering bug
    + fix iconsize temporarily getting large when adding to full dock
      (LP: #579576)
    + fix the 'crash in PinToDock' (LP: #588073)
    + make 3d background height more consistent and a tad larger (LP: #503038)
    + fix dragging multiple files to a folder on the dock, which caused
      a crash and data corruption (LP: #579049)
    + don't request animations if urgent state is removed from a window and
      fix glow location (LP: #596422)
    + fix window previews being offset (LP: #495065)
    + fix broken zoom after shrinking icon size (LP: #598924)
    + fix problem with hovers still visible when painters show
    + fix displaying default icon in place of missing file emblem (LP: #534651)
    + fix crash when gconf key for menus_have_icons is not set (LP: #573751)
    + make sure painters fit on screen (LP: #589978)
    + fix icon minimize animations not working immediately for some newly
      opened windows
    + don't dispose our static DockyItem
    + fix CurrentDesktopOnly not working when dragging a window across desktops
      (LP: #600290)
    + GMail:
      - fix thread-guards and remove deprecated code
      - fix problem with feeds that don't have a...

Read more...

Changed in docky (Ubuntu):
status: New → Fix Released
Revision history for this message
Colin Watson (cjwatson) wrote : Please test proposed package

Accepted docky into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in docky (Ubuntu Lucid):
status: New → Fix Committed
tags: added: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :
Download full text (3.9 KiB)

This bug was fixed in the package docky - 2.0.5-0ubuntu1

---------------
docky (2.0.5-0ubuntu1) lucid-proposed; urgency=low

  * New upstream release 2.0.5 "Be proud of your dock",
    changes include:
    + remove --debug flag from launcher for lower memory usage
    + update the about dialog credits to list documenters and make translation
      tab easier to read
    + change url in about dialog to the launchpad project page
    + Window-Matching
      - fix for applications commandline
      - properly match qt creator (LP: #594814)
      - prefer local over global launchers (LP: #588073) (LP: #592841)
      - match prefix for gksudo (LP: #516433)
      - fix nautilus items showing active indicator when desktop
        is focused (LP: #487113)
      - fix matching wine apps that use a prefixed launcher (LP: #596092)
    + Memory Leaks
      - dispose of calendar painter when the clock item is disposed
      - fix leak in AutoHideManager
      - several fixes using Cairo.Context.Target and Pango.Layout
      - fix leak in PagingPainters
      - fix leak in recursive file-deletion
      - fix leaking SeparatorItems, WnckDockItems
      - fix leaks with FileEmblems
      - fix Pixbuf related leaks
      - fix some leaks regarding FileMonitors
      - fix leaks regarding Tiles and AbtractTileObjects
      - fix leaking Glib.FileAdapter caused by unreferenced Action in
        FileDockItem
    + Handle invalid desktopfile entry and UriFormatException in
      FileApplicationProvider (LP: #595921)
    + fix potential crash for invalid HelperMetadata
    + handle drops correctly
    + fix handling of Helpers in HelperService
    + make the sliders in preferences behave better
    + fix drawing of rotated items
    + fix HoveredItem click-position
    + avoids fatal errors on console when loading embedded icons when no
      height or width is specified and when dock items have a null Icon
    + fix icon theme change not refreshing the dock icons (LP: #590205)
    + fix SVG rendering bug
    + fix iconsize temporarily getting large when adding to full dock
      (LP: #579576)
    + fix the 'crash in PinToDock' (LP: #588073)
    + make 3d background height more consistent and a tad larger (LP: #503038)
    + fix dragging multiple files to a folder on the dock, which caused
      a crash and data corruption (LP: #579049)
    + don't request animations if urgent state is removed from a window and
      fix glow location (LP: #596422)
    + fix window previews being offset (LP: #495065)
    + fix broken zoom after shrinking icon size (LP: #598924)
    + fix problem with hovers still visible when painters show
    + fix displaying default icon in place of missing file emblem (LP: #534651)
    + fix crash when gconf key for menus_have_icons is not set (LP: #573751)
    + make sure painters fit on screen (LP: #589978)
    + fix icon minimize animations not working immediately for some newly
      opened windows
    + don't dispose our static DockyItem
    + fix CurrentDesktopOnly not working when dragging a window across desktops
      (LP: #600290)
    + GMail:
      - fix thread-guards and remove deprecated code
      - fix problem with feeds that do...

Read more...

Changed in docky (Ubuntu Lucid):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.