Zim

Can't add a new customtool after from verno. 263

Bug #596194 reported by YPWang
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Zim
Fix Released
High
Unassigned

Bug Description

Dear All:
      i run the pyzim in ubuntu lucid. i found that i can't add a new customtool after the zim be up to date. i found the function do_response_ok in customtools.py try to get the "path object" after from verno. 263. i delete the "path object" by self. it can't be look good for me.

Debug Msg:
DEBUG: Opening dialog "Custom Tools - Zim"
DEBUG: Opening dialog "Edit Custom Tool - Zim"
DEBUG: Dialog response OK
DEBUG: Running ErrorDialog
ERROR: 'NoneType' object has no attribute 'path'
Traceback (most recent call last):
  File "/home/blue119/iLab/zim/zim/gui/widgets.py", line 874, in do_response
    destroy = self.do_response_ok()
  File "/home/blue119/iLab/zim/zim/gui/customtools.py", line 191, in do_response_ok
    fields['Icon'] = self.iconbutton.get_file().path
AttributeError: 'NoneType' object has no attribute 'path'

Revision history for this message
Jaap Karssenberg (jaap.karssenberg) wrote :

OK, looks like I failed to test this function for tools without an icon. If you do define an icon image all should be fine.

Changed in zim:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Jaap Karssenberg (jaap.karssenberg) wrote :

Fixed in rev277.

Changed in zim:
status: Confirmed → Fix Committed
Revision history for this message
Jaap Karssenberg (jaap.karssenberg) wrote :

Release version 0.48

Changed in zim:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.