help links should be sprites
Bug #595907 reported by
Curtis Hovey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Brad Crittenden | ||
Bug Description
I see we are adding help links that are neither test friendly, or reuse the icon *already loaded* in the sprite file.
This is bad markup:
<a target="help" href="/
<img src="/@@/maybe" alt="help" /></a>
Better markup is:
<a target="help" href="/
class="sprite maybe"><span class="
Related branches
lp:~bac/launchpad/bug-595907
- Jelmer Vernooij (community): Approve (code)
-
Diff: 113 lines (+17/-11)7 files modifiedbuildout-templates/bin/retest.in (+1/-1)
lib/canonical/launchpad/icing/style-3-0.css.in (+4/-0)
lib/lp/bugs/help/tag-help.html (+2/-2)
lib/lp/bugs/templates/bugtask-index.pt (+4/-2)
lib/lp/registry/stories/person/xx-person-home.txt (+2/-2)
lib/lp/registry/templates/person-portlet-contact-details.pt (+2/-2)
lib/lp/registry/templates/product-index.pt (+2/-2)
| Changed in launchpad-web: | |
| status: | Triaged → In Progress |
Revision history for this message
| Curtis Hovey (sinzui) wrote | #1 |
| Changed in launchpad-web: | |
| milestone: | 10.06 → 10.07 |
| Changed in launchpad-web: | |
| milestone: | 10.07 → 10.06 |
| status: | In Progress → Fix Committed |
| tags: | added: qa-ok |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #2 |
| tags: |
added: qa-needstesting removed: qa-ok |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-web: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Even better markup:
<a target="help" href="/
class="sprite maybe"> <span class="
This is the zero-width problem. My fix to the formatters was to ensure there is always a space in the link.
ObjectImageDisp
<span class="sprite %(icon)
Note that we always want to place an before the invisible-link element, or in the anchor if it is being left empty.