couchdb-glib sets its own, custom log handler for the g_debug

The uploaded package has a very unclean diff, it adds a lot of .bzr/ files and removes the pregenerated marshall .h/.c files; are they correctly being regenerated on package build? Also, this update does not seem to have any practical difference for users, so it seems to be very low-priority; at the same time every SRU has a nonzero regression potential, so is that really worth backporting?

I reject the current upload; if you think this is important enough for lucid, please reuplaod a clean package. Thanks!

hmm, I just created a package from the branch kklimonda proposed for merging, so Martin, where can I see that unclean diff?

Rodrigo,

it's here:

http://launchpadlibrarian.net/50064244/couchdb-glib_0.6.3-0ubuntu1_0.6.3-0ubuntu2.diff.gz

You probably need to use debuild -i to avoid including the .bzr stuff; not sure about the marshalling bits.

Package uploaded to lucid-proposed

Needs debdiff on bug

Needs test case on bug

Needs approval from ubuntu-sru

Still needs a rationale, see comment 1.

Martin: As a rationale lets say that I had to debug why doesn't my program display any debug messages when I tell it to. Is it important enough for an SRU? I have no idea, it affects only developers who has probably either already moved on to maverick, found bug and fixed it themselves or decided to work around it. It doesn't affect users directly. Only those who need debug messages for some reason may have a problem finding them.

All that this configure flag changes in source is setting DEBUG_MESSAGES which sets custom handler for G_LOG_LEVEL_DEBUG messages, enables some g_debug messages in code and calls debug_print_headers for all headers from SoupMessage. Maybe Rodrigo can say more about the regression potential then me.

As for the test case I can write a simple C program that shows the problem (I don't think I can access g_debug from python). Would that be sufficient?

Actually I can write a testcase using python and ctypes, here it goes.
You will only see the first message with current lucid version of libcouchdb-glib-1.0-2.

Per SRU policy (https://wiki.ubuntu.com/StableReleaseUpdates) the package needs to be fixed in the dev release before being pushed to a stable release.
Version 0.6.3-0ubuntu2 of the package has been published to lucid-proposed, so please fix in maverick asap.

Thank in advance.

On Mon, 2010-09-06 at 13:29 +0000, Jean-Baptiste Lallement wrote:
> Per SRU policy (https://wiki.ubuntu.com/StableReleaseUpdates) the package needs to be fixed in the dev release before being pushed to a stable release.
> Version 0.6.3-0ubuntu2 of the package has been published to lucid-proposed, so please fix in maverick asap.
>
> Thank in advance.
>
The bug has been fixed in Maverick with 0.6.95-0ubuntu1 upload (which
should link itself to this bug but apparently it hasn't).

SRU verification for Lucid:
I have reproduced the problem with couchdb-glib 0.6.3-0ubuntu1 in lucid and have verified that the version of couchdb-glib 0.6.3-0ubuntu2 in -proposed fixes the issue. I've run the tests shipped with couchdb-glib and found no regression.

Marking as verification-done

This bug was fixed in the package couchdb-glib - 0.6.3-0ubuntu2

---------------
couchdb-glib (0.6.3-0ubuntu2) lucid-proposed; urgency=low

  * debian/rules:
    - Add --disable-debug-messages configure flag (LP: #591873)
 -- Rodrigo Moya <email address hidden> Tue, 17 Aug 2010 09:56:53 +0200