person.inTeam(other_person) hits the db (when both not teams)
Bug #591544 reported by
Tim Penhey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Unassigned | ||
Bug Description
Here is a snippet of my large debugging output. Here I know that user and self.obj.person are both individuals, so there should be no team participation check.
File "/home/
return (user.inTeam(
File "/home/
tp = TeamParticipati
<snippity>
SELECT TeamParticipati
We could special case this to avoid db queries.
Related branches
lp:~sinzui/launchpad/inteam-db-calls-0
- Robert Collins (community): Approve
-
Diff: 344 lines (+85/-83)4 files modifiedlib/lp/registry/doc/person.txt (+0/-25)
lib/lp/registry/doc/teammembership.txt (+23/-50)
lib/lp/registry/model/person.py (+20/-6)
lib/lp/registry/tests/test_person.py (+42/-2)
Revision history for this message
| Curtis Hovey (sinzui) wrote | #1 |
| Changed in launchpad-registry: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| tags: | added: tech-debt |
| Changed in launchpad-registry: | |
| milestone: | none → series-future |
| Changed in launchpad-registry: | |
| milestone: | series-future → 10.10 |
| assignee: | nobody → Curtis Hovey (sinzui) |
| status: | Triaged → In Progress |
| Changed in launchpad-registry: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #2 |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #3 |
| tags: |
added: qa-needstesting removed: qa-ok |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-registry: | |
| status: | Fix Committed → Fix Released |
| Changed in launchpad: | |
| assignee: | Curtis Hovey (sinzui) → nobody |
To post a comment you must log in.
I recall inTeam() also special cases the owner. We should make this method sensible.