Xibo

Logged in lights still funky in 1.1.1

Bug #588443 reported by Alex Harrington on 2010-06-01

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	Xibo	Fix Released	Low	Alex Harrington	Xibo 1.2.0-rc1 "Biela"

Bug Description

I'm logged in to the unittest box and it's showing the logged in light for the Python Client as green but the last access time over 24 hours ago?

Screenshot attached.

Related branches

lp:~alexharrington/xibo/588443

Merged into lp:xibo/1.2 at revision 143

Xibo Maintainters: Pending requested 2010-06-05

Revision history for this message

Alex Harrington (alexharrington) wrote on 2010-06-01:

green_light.png Edit (84.9 KiB, image/png)

Changed in xibo:
status:	New → Confirmed
importance:	Undecided → Low
milestone:	none → 1.2.0-rc1

Revision history for this message

Alex Harrington (alexharrington) wrote on 2010-06-01:

Just checked I get the same output in Chromium.

Alex Harrington (alexharrington) on 2010-06-04

Changed in xibo:
assignee:	nobody → Alex Harrington (alexharrington)

Revision history for this message

Alex Harrington (alexharrington) wrote on 2010-06-04:

Took a look at this. I found one little thing which isn't major but I think needs fixing.

In lib/pages/display.class.php line 284:
http://bazaar.launchpad.net/~xibo-maintainers/xibo/biela/annotate/head%3A/server/lib/pages/display.class.php#L284

Shouldn't the column be named something unique rather than both L282 and L284 being "AS loggedin"?

Perhaps:
CASE WHEN display.inc_schedule = 1 THEN '<img src="img/act.gif">' ELSE '<img src="img/disact.gif">' END AS inc_schedule,

Anyhow the grid that renders the display status seems to be looking at the loggedin column in the DB. I grepped through the code and can find where that's set to 1 but nowhere where it gets set back to 0.

Should this be changed to look at the time differential between display.lastaccessed and now? Is it worth me adding a config setting in the db for that interval too?

Alex Harrington (alexharrington) on 2010-06-05