Ubuntu
cluster-glue package

/usr/lib/stonith/plugins/external/sbd works uses wrong shell commands

Bug #585468 reported by Falk Hackenberger
16
This bug affects 2 people
Affects Status Importance Assigned to Milestone
cluster-glue (Ubuntu)
Fix Released
Undecided
Unassigned
Lucid
Won't Fix
Medium
Unassigned

Bug Description

Binary package hint: cluster-glue

/usr/lib/stonith/plugins/external/sbd
uses ha_log as shell command which is now ha_logger
also the

nodes=$(
    if is_heartbeat; then
       crm_node -H -p
    else
       crm_node -p
    fi)

lines are nor working.
fix is:
    if is_heartbeat; then
        nodes=$(crm_node -H -p)
    else
        nodes=$(crm_node -p)
    fi

source: http://www.gossamer-threads.com/lists/linuxha/pacemaker/63969

patch:
28c28
< ha_log err "sbd could not list nodes from $sbd_device"
---
> ha_logger err "sbd could not list nodes from $sbd_device"
31d30
< nodes=$(
33c32
< crm_node -H -p
---
> nodes=$(crm_node -H -p)
35,36c34,36
< crm_node -p
< fi)
---
> nodes=$(crm_node -p)
> fi
>
39c39
< ha_log warn "no active nodes reported by the CRM"
---
> ha_logger warn "no active nodes reported by the CRM"
44c44
< ha_log err "node $N not accessible through $sbd_device"
---
> ha_logger err "node $N not accessible through $sbd_device"

TEST CASE:
1) Run the sbd daemon with the sbd command in a terminal

VERIFICATION DONE:
Check if the sbd daemon logs something in the /var/log/ha-log file.

See original description
Revision history for this message
Falk Hackenberger (ubuntu-spam-huckley) wrote :

cluster-glue version 1.0.5-1 of Ubuntu 10.04 LTS is affected

Revision history for this message
Ante Karamatić (ivoks) wrote :

It should actually be ha_log.sh, not ha_logger. This is fixed in maverick.

Revision history for this message
Ante Karamatić (ivoks) wrote :

As for the nodes part, looks like upstream removed that part completly in newer releases.

Changed in cluster-glue (Ubuntu):
status: New → Invalid
Changed in cluster-glue (Ubuntu Lucid):
status: New → Triaged
importance: Undecided → Medium
Bilal Akhtar (bilalakhtar)
Changed in cluster-glue (Ubuntu Lucid):
assignee: nobody → Bilal Akhtar (bilalakhtar)
status: Triaged → In Progress
Bilal Akhtar (bilalakhtar)
description: updated
Changed in cluster-glue (Ubuntu Lucid):
status: In Progress → Fix Committed
tags: added: verification-needed
Changed in cluster-glue (Ubuntu Lucid):
assignee: Bilal Akhtar (bilalakhtar) → nobody
Revision history for this message
Martin Pitt (pitti) wrote :

Bilal, please don't add the verification-needed tag to bugs. This is only done when a package is actually in -proposed for testing.

Changed in cluster-glue (Ubuntu):
status: Invalid → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Accepted cluster-glue into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Bilal Akhtar (bilalakhtar)
Changed in cluster-glue (Ubuntu Lucid):
milestone: none → lucid-updates
Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

Someone, PLEASE check if this fix is working or not! Pity I upgraded the last of my Lucid systems to maverick now.

Bilal Akhtar (bilalakhtar)
description: updated
Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

Now I have updated the description with the actual steps of checking this SRU.

description: updated
Revision history for this message
Falk Hackenberger (ubuntu-spam-huckley) wrote : Re: [Bug 585468] Re: /usr/lib/stonith/plugins/external/sbd works uses wrong shell commands

typo: you use ha_log.sh instead of ha_logger
/usr/lib/stonith/plugins/external/sbd: line 43: ha_log.sh: command not found

Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

This isn't a typo, its intended. And, please check thoroughly, since its working for me.

Revision history for this message
Bilal Akhtar (bilalakhtar) wrote :

Oh, and, many plugins, not only the sbd one, are using ha_log.sh with the same arguments and there also its working.

Revision history for this message
Andres Rodriguez (andreserl) wrote :

Unfortunately, I could not test this given that I do not have the required for a test implementation. However, I can confirm that the proposed fix is correct and has been applied in both, Upstream and Debian (In Debian the error was found in 1.0.5-2 and was fixed in 1.0.6).

The only thing I can say is that the patch is correct and *should*, however, I cannot test it.

Revision history for this message
Andres Rodriguez (andreserl) wrote :

Debian bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=585120
Upstream: http://hg.linux-ha.org/glue/rev/1be1b01ddd1c

Revision history for this message
Martin Pitt (pitti) wrote :

Any testers of the proposed package? We at least need to know that the package still by and large works, to rule out misbuilds, etc.

Revision history for this message
Martin Pitt (pitti) wrote :

2011-01-25 09:05:53 INFO Removing candidates:
2011-01-25 09:05:53 INFO cluster-glue 1.0.5-1ubuntu0.1 in lucid
2011-01-25 09:05:53 INFO Removed-by: Martin Pitt
2011-01-25 09:05:53 INFO Comment: unverified SRU
2011-01-25 09:05:53 INFO 25 packages successfully removed.

Changed in cluster-glue (Ubuntu Lucid):
milestone: lucid-updates → none
status: Fix Committed → Won't Fix
Ubuntu Foundations Team Bug Bot (crichton)
tags: added: testcase
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.