HEAD breaks testdrive -u ./foo.iso

Bug #581067 reported by Dustin Kirkland 
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
TestDrive
Fix Released
High
Unassigned

Bug Description

Testing the head branch, with Andres' recent refactoring, running against a local ISO is broken.

Let's get that fixed before releasing 1.39.

Related branches

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

kirkland@x200:/local/virt/iso$ testdrive -u lucid-desktop-amd64.iso
INFO: version passed: False

INFO: config passed: None

INFO: Trying config in /etc/testdriverc

INFO: Using configuration in /etc/testdriverc

INFO: Trying config in /home/kirkland/.testdriverc

INFO: Trying config in /home/kirkland/.config/testdrive/testdriverc

INFO: Using KVM for virtual machine hosting...

INFO: Retrieving Ubuntu Development Release codename from cache...

INFO: Syncing the specified ISO...

      file://lucid-desktop-amd64.iso

Traceback (most recent call last):
  File "/usr/bin/testdrive", line 368, in <module>
    main()
  File "/usr/bin/testdrive", line 334, in main
    run_or_die(cmd)
  File "/usr/bin/testdrive", line 85, in run_or_die
    if run(cmd) != 0:
  File "/usr/bin/testdrive", line 82, in run
    return(os.system(cmd))
TypeError: system() argument 1 must be string, not None

Changed in testdrive:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Andres Rodriguez (andreserl)
Revision history for this message
Dustin Kirkland  (kirkland) wrote :

This looks wrong:

        info("Syncing the specified ISO...")
        print(" %s" % td.ISO_URL)
        cmd = td.get_proto()
        print(cmd)
        if cmd == 0:
                error("ISO not found at [%s]" % td.ISO_URL)
        elif cmd == 1:
                error("Unsupported protocol [%s]" % td.PROTO)
        run_or_die(cmd)

Changed in testdrive:
status: Triaged → In Progress
Changed in testdrive:
status: In Progress → Fix Committed
assignee: Andres Rodriguez (andreserl) → nobody
Changed in testdrive:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.