Ubuntu
initramfs-tools package

initramfs-tools and casper should use shell syntax checking in check target

Bug #570243 reported by Evan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
casper (Ubuntu)
Fix Released
Low
Unassigned
initramfs-tools (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: initramfs-tools

Ubiquity does the following in make check:
        # Check the syntax of any shell scripts.
        set -e; for x in $$(find -type f -print0 | xargs -0 file -i | grep "text/x-shellscript" | cut -d':' -f1); do \
                sh -n $$x; \
        done

As casper and initramfs-tools could stand to benefit from such a safeguard, they should make use of it as well.

Revision history for this message
maximilian attems (maks-debian) wrote :

we do so in initramfs-tools for boot and hook scripts. This is fixed since 0.97 and thus incorporated since Maverick in Ubuntu.

Changed in initramfs-tools (Ubuntu):
status: New → Fix Released
Brian Murray (brian-murray)
Changed in casper (Ubuntu):
importance: Undecided → Low
Brian Murray (brian-murray)
Changed in casper (Ubuntu):
status: New → Triaged
Stéphane Graber (stgraber)
Changed in casper (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package casper - 1.327

---------------
casper (1.327) quantal; urgency=low

  [ Tim Lunn ]
  * add gnome-shell favorites tweak to 25adduser
  * Add 16gdmnopasswd script, removes gdm password dialog for live user.

  [ Stéphane Graber ]
  * Fix casper when running on some RAID systems. (LP: #1047316, LP: #965735)
  * Apply patch by Tyler Gates to try and better handle dm devices, should help
    with the above change too. (LP: #865529)
  * Use /sys/class/net/ instead of hardcoded eth* devices.
    (LP: #905828, LP: #962546)
  * Allow overriding username/userfullname/hostname on the boot command line
    as is mentioned in the manpage but was never implemented.
    Note that when using persistence, those used for the first boot will be
    remembered through /etc/casper.conf (LP: #907482)
  * Reset oem-config/enable to false every boot. (LP: #838680)
  * Add Breaks/Replaces to ubiquity-casper to properly upgrade when both
    casper and ubiquity-casper are installed. (LP: #1046300)
  * Apply patch by cleary to avoid hang in 41apt_cdrom when .disk/info doesn't
    exist. (LP: #909919)
  * Eject by block device instead of mountpoint, this should avoid ejecting
    the cdrom on USB installations. (LP: #869238)
  * Add 'check' target to debian/rules based on ubiquity's (LP: #570243)
 -- Stephane Graber <email address hidden> Wed, 03 Oct 2012 17:46:39 -0400

Changed in casper (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.