reorganise stylesheet
Bug #569054 reported by
Curtis Hovey
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Curtis Hovey | ||
Bug Description
After passes of moving old styles into the new style sheet, the file has become difficult to read.
* Move universal selectors to the 3.0 CSS
* Use consistent formatting for CSS and comment.
* Reoragnise the CSS into sections that will group similar selectors.
This allows us to see similar selector. It encourages fixing the
current rules instead of writing new ones. This also makes it easy
to find similar and duplicate rules.
Related branches
lp:~sinzui/launchpad/css-rip-0
- Michael Nelson (community): Approve (code)
-
Diff: 3372 lines (+1482/-1213)2 files modifiedlib/canonical/launchpad/icing/style-3-0.css.in (+1481/-934)
lib/canonical/launchpad/icing/style.css (+1/-279)
Revision history for this message
| Jonathan Lange (jml) wrote | #1 |
| Changed in launchpad-web: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #2 |
| Changed in launchpad-web: | |
| milestone: | none → 10.04 |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
Revision history for this message
| Curtis Hovey (sinzui) wrote Bug 569054 Fix released | #3 |
| Changed in launchpad-web: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Cool!
Can you please send out an email to the launchpad-dev list when you are done, explaining this brave new world for us all?