Ubuntu
totem package

TypeError in bbc plugin

Bug #563671 reported by sam tygier on 2010-04-15

8

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	totem (Ubuntu)	Fix Released	Low	Unassigned

Bug Description

Binary package hint: totem

when starting the bbc plugin i get the error

(totem:22470): GLib-GObject-WARNING **: IA__g_object_set_valist: object class `GstPlayBin2' has no property named `queue-size'
Traceback (most recent call last):
  File "/usr/lib/totem/plugins/bbc/contentview.py", line 825, in _on_content_pool_loading_done
    self.populate()
  File "/usr/lib/totem/plugins/bbc/contentview.py", line 855, in populate
    genre.add_brand(brand)
  File "/usr/lib/totem/plugins/bbc/genres.py", line 247, in add_brand
    gst.log(self.short_ref + ': adding show ' + brand.title)
TypeError: cannot concatenate 'str' and 'NoneType' objects

this turns out to be because brand.title is None.

i tried using str() to allow the None to be send to gst.log, but they cause problems later on.

a better solution seems to be to return early from the function. see attached patch. with the patch i can load the bbc plugin and listen to most feeds.

ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: totem 2.30.0-0ubuntu3
ProcVersionSignature: Ubuntu 2.6.32-20.30-generic 2.6.32.11+drm33.2
Uname: Linux 2.6.32-20-generic x86_64
Architecture: amd64
Date: Thu Apr 15 10:35:22 2010
InstallationMedia: Ubuntu 9.10 "Karmic Koala" - Release amd64 (20091027)
ProcEnviron:
SHELL=/bin/bash
PATH=(custom, user)
LANG=en_GB.utf8
SourcePackage: totem

Tags:

Related branches

lp:~ubuntu-desktop/totem/ubuntu

lp:ubuntu/maverick/totem

Revision history for this message

sam tygier (samtygier) wrote on 2010-04-15:

#1

Dependencies.txt Edit (5.5 KiB, text/plain; charset="utf-8")
GstreamerVersions.txt Edit (2.0 KiB, text/plain; charset="utf-8")
LogAlsaMixer.txt Edit (3.7 KiB, text/plain; charset="utf-8")
XorgLog.txt Edit (54.0 KiB, text/plain; charset="utf-8")

fixbbc.diff Edit (369 bytes, text/plain)

Revision history for this message

Sebastien Bacher (seb128) wrote on 2010-04-15:

#2

Thank you for your bug report; I can confirm the issue there though

Changed in totem (Ubuntu):
importance:	Undecided → Low

Revision history for this message

Sebastien Bacher (seb128) wrote on 2010-04-15:

#3

It's also worth noting that the bbc code is Ubuntu specific so this bug should not be sent to GNOME

Revision history for this message

sam tygier (samtygier) wrote on 2010-04-15:

#4

were is the totem plugin's source code? if it do
bzr branch pl:totem
i dont get it.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-06-25:

#5

This bug was fixed in the package totem - 2.30.2-2ubuntu1

---------------
totem (2.30.2-2ubuntu1) maverick; urgency=low

  * debian/patches/70_bbc_plugin.patch:
    - Fix crash in BBC plugin, thanks Sam Tygier (LP: #563671)
  * Merge with Debian unstable, remaining Ubuntu changes:
  * debian/control:
    - Build-depend on gnome-common for autotools
    - Don't build using libepc, galago those are in universe
    - Don't use libtracker, the current version is not very useful and not
      something to recommend to users and totem requires a newer version
    - Remove superfluous xulrunner-dev build-depend
    - Build-depend on liblaunchpad-integration-dev
    - Add Vcs-Bzr link
    - totem-plugins doesn't depend on python-gdata since libgdata is used
      instead nowadays
    - Add XB-Npp-Description and XB-Npp-Filename header to the
      totem-mozilla package to improve ubufox/ubuntu plugin db integration
    - Change refences from Iceweasel to Firefox
    - Split totem-plugins package in an extra package for the components
      which have depends in universe
    - Use suggests rather than recommends for universe gstreamer components
    - Add totem-plugins-extra package
  * debian/rules:
    - Run autotools on build
  * debian/source_totem.py:
    - Apport hook
  * debian/totem-common.gconf-defaults:
    - Activate content retrieval plugins (BBC and YouTube) by default
  * debian/totem-common.install:
    - Install apport hook
  * debian/totem-plugins-extra.install:
    - Plugins split out ouf totem-plugins
  * debian/totem-plugins.install:
    - Move some plugins to totem-plugins-extra
  * debian/totem.preinst:
    - No longer required as Lucid has been released
  * debian/patches/02_lpi.patch:
    - Launchpad integration
  * debian/patches/07_disable_web_browser_midi.patch:
    - Karmic's version of gstreamer does not support MIDI over HTTP
  * debian/patches/70_bbc_plugin.patch:
    - Updated from upstream bug report
  * debian/patches/90_autotools.patch:
    - Not required, autotools run from debian/rules
  * debian/patches/91_git_correct_rgba_use.patch:
    - git change to fix totem crashing with gtk csd
  * debian/watch:
    - Watch for unstable versions
-- Robert Ancell <email address hidden> Fri, 25 Jun 2010 13:53:18 +1000

This bug was fixed in the package totem - 2.30.2-2ubuntu1

---------------
totem (2.30.2-2ubuntu1) maverick; urgency=low

* debian/patches/70_bbc_plugin.patch:
    - Fix crash in BBC plugin, thanks Sam Tygier (LP: #563671)
  * Merge with Debian unstable, remaining Ubuntu changes:
  * debian/control:
    - Build-depend on gnome-common for autotools
    - Don't build using libepc, galago those are in universe
    - Don't use libtracker, the current version is not very useful and not
      something to recommend to users and totem requires a newer version
    - Remove superfluous xulrunner-dev build-depend
    - Build-depend on liblaunchpad-integration-dev
    - Add Vcs-Bzr link
    - totem-plugins doesn't depend on python-gdata since libgdata is used
      instead nowadays
    - Add XB-Npp-Description and XB-Npp-Filename header to the
      totem-mozilla package to improve ubufox/ubuntu plugin db integration
    - Change refences from Iceweasel to Firefox
    - Split totem-plugins package in an extra package for the components
      which have depends in universe
    - Use suggests rather than recommends for universe gstreamer components
    - Add totem-plugins-extra package
  * debian/rules:
    - Run autotools on build
  * debian/source_totem.py:
    - Apport hook
  * debian/totem-common.gconf-defaults:
    - Activate content retrieval plugins (BBC and YouTube) by default
  * debian/totem-common.install:
    - Install apport hook
  * debian/totem-plugins-extra.install:
    - Plugins split out ouf totem-plugins
  * debian/totem-plugins.install:
    - Move some plugins to totem-plugins-extra
  * debian/totem.preinst:
    - No longer required as Lucid has been released
  * debian/patches/02_lpi.patch:
    - Launchpad integration
  * debian/patches/07_disable_web_browser_midi.patch:
    - Karmic's version of gstreamer does not support MIDI over HTTP
  * debian/patches/70_bbc_plugin.patch:
    - Updated from upstream bug report
  * debian/patches/90_autotools.patch:
    - Not required, autotools run from debian/rules
  * debian/patches/91_git_correct_rgba_use.patch:
    - git change to fix totem crashing with gtk csd
  * debian/watch:
    - Watch for unstable versions
 -- Robert Ancell <robert.ancell@canonical.com>   Fri, 25 Jun 2010 13:53:18 +1000

Changed in totem (Ubuntu):
status:	New → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Patches

fixbbc.diff Edit

Add patch

Bug attachments

Add attachment

Remote bug watches

Bug watches keep track of this bug in other bug trackers.