Tomdroid

the search-bar search also XML tags

Bug #562089 reported by Edouard Richard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Tomdroid
Fix Released
Low
Unassigned
Tomdroid 0.6.0 "Small World"

Bug Description

I don't see how can I ignore XML tags in the 'content' column while SQL query.
By example, when I search 'note', all notes are showed because there is "<note-content>..</note-content>"
Is it possible to do it directly in the query ?

Related branches

lp:~vbkaisetsu/tomdroid/sql-args
Olivier Bilodeau: Needs Fixing
Diff: 440 lines (+190/-33)
5 files modified
src/org/tomdroid/Note.java (+7/-1)
src/org/tomdroid/NoteManager.java (+42/-14)
src/org/tomdroid/NoteProvider.java (+73/-18)
src/org/tomdroid/sync/sd/NoteHandler.java (+17/-0)
src/org/tomdroid/util/StringConverter.java (+51/-0)
lp:~vbkaisetsu/tomdroid/search-without-xml
Tomdroid Maintainers: Pending requested
Diff: 225 lines (+107/-8)
4 files modified
src/org/tomdroid/Note.java (+1/-0)
src/org/tomdroid/NoteManager.java (+12/-6)
src/org/tomdroid/NoteProvider.java (+57/-2)
src/org/tomdroid/util/StringConverter.java (+37/-0)
Revision history for this message
Olivier Bilodeau (plaxx) wrote :

note-content tags are kept in the database and now I start to regret it ;)

I think that in all the work related to 0.4 it could have been removed.. Can you try updating to what is in lp:tomdroid now and verify?

Changed in tomdroid:
importance: Undecided → Low
Revision history for this message
Stefan Hammer (j-4-deactivatedaccount) wrote :

The bug is not present, when syncing with Ubuntu One. It seems, that they are removing the tags.
With our test notes and SD card sync all notes showing up when searching for "note", "content" or "version".

All notes are coming up in both cases, when searching with > or <, but I think we can ignore this.
Do you have an idea how to fix this issue? I could do it, but atm I don't know what would be the best solution.

Changed in tomdroid:
status: New → Confirmed
Koichi Akabe (vbkaisetsu)
Changed in tomdroid:
assignee: nobody → Koichi Akabe (vbkaisetsu)
status: Confirmed → In Progress
Revision history for this message
Koichi Akabe (vbkaisetsu) wrote :

I solved it on my branch: https://code.launchpad.net/~vbkaisetsu/tomdroid/sql-args

I added new column "content_plain" to the database. This column stores plain text contents which are created from XML contents. I changed SQL query to search it and this bug was solved.

Stefan Hammer (j-4-deactivatedaccount)
Changed in tomdroid:
milestone: none → 0.5.1
Koichi Akabe (vbkaisetsu)
Changed in tomdroid:
assignee: Koichi Akabe (vbkaisetsu) → nobody
Koichi Akabe (vbkaisetsu)
Changed in tomdroid:
status: In Progress → Fix Committed
Stefan Hammer (j-4-deactivatedaccount)
Changed in tomdroid:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.