Ubuntu
gtk+2.0 package

Using "Save As" without a file name causes f-spot save as dialog to hang

Bug #551384 reported by Rick Spencer on 2010-03-30

This bug affects 1 person

Affects		Status	Importance	Assigned to	Milestone
	gtk+2.0 (Ubuntu)	Fix Released	Medium	Cody Russell	Ubuntu ubuntu-10.04-beta-2
	Lucid	Fix Released	Medium	Cody Russell	Ubuntu ubuntu-10.04-beta-2

Bug Description

Binary package hint: f-spot

Steps:

1. In nautilus, right click on a photo and choose Open in F-Sport
2. Crop the photo using the cropping tool
3. Choose File -> Save As
4. Navigate to a directory and click Save button (while the filename text entry is still empty)

Result:
The dialog becomes unclickable and non-dismissable.

Expected:
The Save button is disabled until there is a file name and/or
Nothing happens if I click Save button and there is no name

ProblemType: Bug
DistroRelease: Ubuntu 10.04
Package: f-spot 0.6.1.5-2ubuntu5
ProcVersionSignature: Ubuntu 2.6.32-18.27-generic 2.6.32.10+drm33.1
Uname: Linux 2.6.32-18-generic i686
Architecture: i386
Date: Mon Mar 29 19:44:54 2010
InstallationMedia: Ubuntu 9.10 "Karmic Koala" - Release i386 (20091028.5)
ProcEnviron:
LANG=en_US.utf8
SHELL=/bin/bash
SourcePackage: f-spot

Tags:

Related branches

lp:ubuntu/lucid/gtk+2.0

Revision history for this message

Rick Spencer (rick-rickspencer3) wrote on 2010-03-30:

Dependencies.txt Edit (6.8 KiB, text/plain; charset="utf-8")

Changed in f-spot (Ubuntu):
importance:	Undecided → Medium
assignee:	nobody → Chris Halse Rogers (raof)

Revision history for this message

Rick Spencer (rick-rickspencer3) wrote on 2010-03-30:

I suppose this is really a data loss bug .. consider raising importance

Revision history for this message

Chris Halse Rogers (raof) wrote on 2010-03-31:

Moving to gtk-sharp; this looks to be a problem in the FileChooserDialog. It's a pretty obnoxious bug where the save dialog can freeze!

affects:	f-spot (Ubuntu) → gtk-sharp2 (Ubuntu)
Changed in gtk-sharp2 (Ubuntu):
importance:	Medium → High
status:	New → Confirmed

Revision history for this message

Chris Halse Rogers (raof) wrote on 2010-03-31:

Ok. This is actually a gtk+ bug. I'll attach a minimal test case where hitting “save” simply hangs the dialog.

Changed in gtk-sharp2 (Ubuntu):
assignee:	Chris Halse Rogers (raof) → nobody
affects:	gtk-sharp2 (Ubuntu) → gtk+2.0 (Ubuntu)

Revision history for this message

Chris Halse Rogers (raof) wrote on 2010-03-31:

Minimal test case to illustrate bug Edit (595 bytes, text/plain)

Here's a C file you can build with
gcc -o test Testifu.c $(pkg-config --cflags gtk+-2.0) $(pkg-config --libs gtk+-2.0)

Run it, and hit “save” - the dialog will hang.

Changed in gtk+2.0 (Ubuntu):
assignee:	nobody → Canonical Desktop Team (canonical-desktop-team)

Martin Pitt (pitti) on 2010-03-31

Changed in gtk+2.0 (Ubuntu Lucid):
importance:	High → Medium
status:	Confirmed → Triaged

Revision history for this message

Sebastien Bacher (seb128) wrote on 2010-03-31:

the change seems to be due to fileselector fix we added recently, Cody could you have a look to the issue before lucid? the suggestion to have the button unsensitive until something is entered seems to make sense

Changed in gtk+2.0 (Ubuntu Lucid):
assignee:	Canonical Desktop Team (canonical-desktop-team) → Cody Russell (bratsche)
assignee:	Cody Russell (bratsche) → nobody

Revision history for this message

Sebastien Bacher (seb128) wrote on 2010-03-31:

The change which created the issue is

  * debian/patches/064_initial_fileselector_select.patch:
    - change by Cody Russell to fix the default action not working in the
      gtkfileselector until you selected a directory (lp: #80755, #181788)

Changed in gtk+2.0 (Ubuntu Lucid):
assignee:	nobody → Cody Russell (bratsche)

Brian Murray (brian-murray) on 2010-04-01

Changed in gtk+2.0 (Ubuntu Lucid):
milestone:	none → ubuntu-10.04-beta-2

Cody Russell (bratsche) on 2010-04-02

Changed in gtk+2.0 (Ubuntu Lucid):
status:	Triaged → In Progress

Revision history for this message

Cody Russell (bratsche) wrote on 2010-04-02:

Proposed patch Edit (738 bytes, text/plain)

This should replace my previous patch, which is already in Lucid.

Revision history for this message

Cody Russell (bratsche) wrote on 2010-04-06:

This patch has been accepted upstream and I've pushed it into master, at commit b6d9bb6e1e6e916fc2ef25f5729b30ba91979597

Sebastien Bacher (seb128) on 2010-04-06

Changed in gtk+2.0 (Ubuntu Lucid):
status:	In Progress → Fix Committed

Revision history for this message

Launchpad Janitor (janitor) wrote on 2010-04-09:

#10

This bug was fixed in the package gtk+2.0 - 2.20.0-0ubuntu4

---------------
gtk+2.0 (2.20.0-0ubuntu4) lucid; urgency=low

  * debian/patches/064_initial_fileselector_select.patch:
    - replaced by the version commited upstream, thank Cody Russell,
      the update solves f-spot hanging when saving an image without entering
      the name to use in the selector (lp: #551384)
-- Sebastien Bacher <email address hidden> Tue, 06 Apr 2010 16:11:28 +0200