Ubuntu
puppet package

puppet should recommend etckeeper

Bug #546677 reported by Nicolas Valcarcel
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
puppet (Ubuntu)
Invalid
Wishlist
Nicolas Valcarcel

Bug Description

Binary package hint: puppet

Puppet needs to depend or at least recommend etckeeper, it fails to load silently because puppet.conf reads:
prerun_command=/etc/puppet/etckeeper-commit-pre
postrun_command=/etc/puppet/etckeeper-commit-post

Nicolas Valcarcel (nvalcarcel)
Changed in puppet (Ubuntu):
assignee: nobody → Nicolas Valcárcel (nvalcarcel)
Revision history for this message
Paul Elliott (omahn) wrote :

Confirmed - currently marks etckeeper as suggested rather than depends.

Changed in puppet (Ubuntu):
status: New → Confirmed
Revision history for this message
Mathias Gug (mathiaz) wrote : Re: etckeeper is not installed by default when puppet is installed

Puppet should not failed. If etckeeper is not available puppet would just skip it. A dependency is definitely to strong. Either a suggests or a recommends.

I've put a suggests for now until we make etckeeper rock-solid.

Changed in puppet (Ubuntu):
importance: Undecided → Wishlist
summary: - Puppet fails silently if etckeeper isn't installed
+ etckeeper is not installed by default when puppet is installed
Mathias Gug (mathiaz)
summary: - etckeeper is not installed by default when puppet is installed
+ puppet should recommend etckeeper
Changed in puppet (Ubuntu):
status: Confirmed → Triaged
Revision history for this message
Nicolas Valcarcel (nvalcarcel) wrote :

As far as i've tested it's not skipping it, recommends should be then.

Revision history for this message
Nicolas Valcarcel (nvalcarcel) wrote :

Branch updated accodinly

Revision history for this message
Mathias Gug (mathiaz) wrote : Re: [Bug 546677] Re: puppet should recommend etckeeper

On Thu, Mar 25, 2010 at 03:44:59PM -0000, Nicolas Valcárcel wrote:
> As far as i've tested it's not skipping it,

What do you mean by not skipping it? Does puppet actually fails to run
correctly if etckeeper is not available?

--
Mathias Gug
Ubuntu Developer http://www.ubuntu.com

Revision history for this message
Nicolas Valcarcel (nvalcarcel) wrote :

Yup, with no errors

Revision history for this message
Thierry Carrez (ttx) wrote :

At this point we shouldn't force etckeeper on every puppet system... A "Suggests" looks good to me. However puppet needs to be fixed so as to gracefully make use of etckeeper if present, but not fail in any way if it's not...

Revision history for this message
Mathias Gug (mathiaz) wrote :

On Tue, Mar 30, 2010 at 08:23:44AM -0000, Thierry Carrez wrote:
> At this point we shouldn't force etckeeper on every puppet system... A
> "Suggests" looks good to me.

Agreed.

> However puppet needs to be fixed so as to
> gracefully make use of etckeeper if present, but not fail in any way if
> it's not...
>

It should not fail if etckeeper is not installed.

Nicolas could you outline specifically how puppet fails to run?

Could you post debug logs from a puppet run with the --verbose --debug options?

  status incomplete

--
Mathias Gug
Ubuntu Developer http://www.ubuntu.com

Changed in puppet (Ubuntu):
status: Triaged → Incomplete
Revision history for this message
Gustavo Picón (tabo) wrote :

I am the one who originally reported this bug to Nicolas (I couldn't login to lp). Had this problem when the first 10.04 images were available in EC2, but I can confirm now (april 14) that it can't be reproduced in either EC2 or a local test server. So yes, puppet can be installed and runs without etckeeper.

Revision history for this message
Mathias Gug (mathiaz) wrote :

On Wed, Apr 14, 2010 at 08:01:44PM -0000, Gustavo Picón wrote:
> I am the one who originally reported this bug to Nicolas (I couldn't
> login to lp). Had this problem when the first 10.04 images were
> available in EC2, but I can confirm now (april 14) that it can't be
> reproduced in either EC2 or a local test server. So yes, puppet can be
> installed and runs without etckeeper.
>

Thanks.

  status invalid

--
Mathias Gug
Ubuntu Developer http://www.ubuntu.com

Mathias Gug (mathiaz)
Changed in puppet (Ubuntu):
status: Incomplete → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.