receiving messages containing a newline do not show with the ubuntu theme

When I said each messenger, I meant to say each messenger protocol. I was using Empathy the entire time.

@Noremacam, please could you include a screenshot of this issue into your report? Thanks in advance!

OK, I made a mistake. I did get a list message working on googletalk, so it may be dependent on protocol I got it to error twice on MSN messenger now. I may have made a mistaken observation in the past. The screenshot shows the received message in the popup on the right, while not displaying on the chat window itself. For the record, I made sure I didn't receive that message from a different account with the same name. :-)

Noremacam, can you please change your empathy theme to default and see if you still get the problem. This will be really helpful. Thanks

I've just noticed this behaviour in Empathy 2.30.0 with MSN. My chat theme is set to "Ubuntu".

I have the exact same problem using the "Ubuntu" theme in Lucid.

Can any one please confirm if this works fine without 'ubuntu' theme in
empathy?

I confirm it's only the ubuntu theme.
I just switched to the classic theme and received a newline message fine.

I can't reproduce this with either an MSN account or gtalk account using the ubuntu theme.

I also cannot reproduce it with an ICQ account (tested Empathy -> Empathy and Pidgin -> Empathy).

I can confirm this bug.

Installed Ubuntu 10.04 Lucid earlier today, and have applied every update.
I chatted with a friend on the MSN network, and got notifications in the upper right corner of the screen with the message. But when opening the window again (which was minimized on the taskbar), the message was not there. This happened three times in a row, so I was about to report a bug, which is why I found this bugreport.

Using Ubuntu theme, and every other standard settings.

Kind regards from Norway. (You think this could have anything with the language we use in the chat?! Special characters, like the Norwegian Æ Ø and Å maybe? ;))

The person I'm chatting with is writing to me in Windows, using Windows Live Messenger 2009, build 14.0.8089.726.

// jorno

This is a screenshot of the problem, using Ubuntu theme.

And this is a screenshot of an example with Shift+Enter, using Classic theme. Works as expected! :-)

Hi. I have the same problem here with the Ubuntu theme and MSN.
With the original theme Renkoo http://www.adiumxtras.com/index.php?a=xtras&xtra_id=2160 I have the same problem, but in another gnu/linux distribution.
If I change to Classic or Clean for example, works fine.

The same issue exists with the adium theme 'Ravenant'
Have had this for some time, happy that a fix was to just change the theme :)

The whole purpose to a newline in any chat window would be if you were copying text into the window that had a new line, which in my test it worked fine (see attached screenshot). I am using the Ubuntu theme.

Invalid? It happens here on 3 different systems on that particular theme.. Doesn't seem too invalid for me..

How are you trying to add the newlines to the chat. Are you just hitting enter? Are you just copying and pasting text? Could you provide us with some test text example to copy and paste? Maybe some steps to reproduce the issue for your case in specific?

Brian: Look at #12.

In my example, I used the Ubuntu theme, and the person I chatted with used Windows Live Messenger 2009, build 14.0.8089.726. (As stated in #12 ).

If you look at the screenshots I also provided ( #13 and #14 ), you could see examples of text.

This was from a person typing, using Shift+Enter (or is it Ctrl+Enter?) to do a newline, without sending it immediately. And then send it after a couple of newlines.

It should be easy to reproduce, but if you want I could always install Windows into a VirtualBox and try it once more.

Hmm. Gotta be with just MSN only. The lucid tasks are closed as it will be fixed for the Meerkat (once we find out whats causing this), from there we'll look into backporting if needed.

I tend to agree with Brian -- seems to affect only MSN. Also, I have tested several other Adium themes. Most seemed to work, but eventually messages desapeared JUST LIKE with the ubuntu theme.

Looking at the logs, MSN uses 0d 0a for line break, while gtalk et al use only 0a. Could this break the rendering in the IM windows?

Sadly, this sad excuse for an IM protocol is quite used here in Brazil, and I should expect it to be popular elsewhere also. Shouldn't it be getting some higher priority ?

Why do you mark this as "Fix Released" when several people tell you that they still experience this problem? I can confirm that the bug still exists and it's quite serious too, as it can cause the users to miss important messages.

Seems to work
Just added a line to substitute CR+LF for '\n' on incoming text messages. I'm not sure it's a safe solution, though.

So, empathy message rendering code has problems ?

Mr Blonde, I was still trying to figure out what the exact cause of the problem is. Feel free to mark it as confirmed for now as you have, but maybe you could have approached this a little differently.

I have same issue with Ubuntu 10.04 + Empathy 2.30.1. Like sayd, when a arriving message contains newline character (I let my chat buddy do shift+enter in WLM to test) it won't show up in chat window. It will shot up in chat log and when the chat window ain't focussed a notification popup will also show the message. It just ain't showing up in the chat window with the "Ubuntu" theme. Switching to classic fixed it also for me.

I'm affected too. See http://launchpadlibrarian.net/40660364/Screenshot.png for another screenshot.

If any devs want to try to reproduce this problem, please make sure there are conversation lines *before* one with a newline in it, since there's additional weirdness going on depending on whether the offending message opens a conversation, and whether there is a chat history to display or not.

Also, note that the missing lines do display in the chat logs, even though these use the Ubuntu theme too. It's the real-time window updates that fail.

I can't reproduce this using MSN with both ends are using empathy as the client. Based on all the comments and the attached patch for telepathy-butterfly that apparently fixes this issue, I am thinking this must be specific to one end of the conversation using MSN messenger. If that is the case, perhaps the patch to telepathy-butterfly is sufficient, however it makes me think there may be other clients that send the same characters for a newline and perhaps empathy's adium support should handle that on the rendering side. I'll continue to investigate.

Try aMSN for the other end, I can reproduce the problem that way on one computer using two MSN accounts.

Upstream bug https://bugzilla.gnome.org/show_bug.cgi?id=620903

It's a problem in Empathy yes, but in the mean time and just to be sure we applied Rodrigo patch in telepathy-butterfly 0.5.11 we just released. Thanks Rodrigo

I marked it invalid for empathy, upstream will track making empathy handle that case. The only current known occurrence of the bug comes from MSN, so the fix for telepathy-butterfly is sufficient for ubuntu.

Chances of an SRU with the fix?

the new telepathy-butterfly will be synced from debian to maverick when uploaded there

I was going to work on the telepathy-butterfly update to lucid so taking the task

Sebastien the commit is here if you want to import it for lucid : http://git.collabora.co.uk/?p=telepathy-butterfly.git;a=commitdiff;h=67d700f310a869fc16d7b793ae75727cd24e68ce

sru team, the debdiff for the lucid update is on bug #570346

Thanks Olivier, I did an upload of 0.5.11 as a candidate update for lucid

Accepted telepathy-butterfly into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

the new version is in maverick as well now

This bug occurs to me in Empathy version 2.30.1-0ubuntu1 on Lucid, I am guessing the fix is in proposed? I can send large messages, but when I receive one on MSN it will only show up in the notify-osd. It does not show up in the chat window and trying to access the chat history crashes. Also, I noticed sometimes a friends message will show up under the box that contains my messages. I will test using another chat theme to see if this occurs, then restart empathy and see if I can view chat history.

Changing the theme (I used "Clean") allowed me to view it under history.

could you test the upgrade and confirm it's working for you?

pushed to -proposed:

empathy (2.30.1.1-0ubuntu1) lucid-proposed; urgency=low

  * New upstream release:
    - empathy_dispatcher_join_muc: assertion failed: (connection_data != NULL)
      when joining favorites rooms while account is connecting
      (Guillaume Desmottes)
     - Possible to open multiple accounts dialog (Danielle Madeley)
     - Fixed build failure due to missing header (Jasper Lievisse
       Adriaanse)
     - Empathy accounts CC module calls textdomain (Rob Bradford)
     - Should call gtk_builder_set_translation_domain on GtkBuilder
       UI components (Rob Bradford)
     - Empathy silently fails importing contacts from Pidgin
       (Guillaume Desmottes) (LP: #550569)
     - Empathy should use port 8001 to connect to freenode irc (Brian Curtis)
       (LP: #568901)
     - IRC account: don't allow to save changes when editing network
       details (Guillaume Desmottes)
     - Incomplete localisation of g-c-c module (Rob Bradford)
     - Avatar chooser can enter infinite loop (Xavier Claessens)
     - configure script not compatible with dash as /bin/sh (Simon McVittie)
     - crash on 0-byte file in log search (Robert McQueen)
     - "Network error" on connecting to Facebook Chat (Guillaume Desmottes)
       (LP: #542836)
     - "Previous Conversations" Search entry is not activatable
       (Guillaume Desmottes)
     - empathy hangs with high cpu load when changing avatar (Xavier
       Claessens)
     - "Join favorites" should deal better with connecting accounts
       (Guillaume Desmottes)
     - Status reported by account dialog is wrong in connman mode
       (Rob Bradford)
     - accounts_dialog_update_status_infobar mixes const and
       allocated strings for message (Rob Bradford)
     - Empathy should not requires that geoclue providers support
       updates (Laurent Bigonville)
     - some messages get dropped when using adium themes (Guillaume
       Desmottes) (LP: #546338)
     - empathy does not set geoclue requirements before asking for
       address/position (Laurent Bigonville)
     - Missing image icon shows up when contact has no avatar
       (Frédéric Péters)
     - Crash when trying to start a camera preview without a camera
       (Sjoerd Simons)
    - updated translations
  * added debian/patches/90_revert_removal_stock_person.patch:
    remove upstream git commit b87a2f274a838e8636c64605506e6ba243c2671a
    ad we don't have gnome-icon-theme 2.30

Testcase:
- run the package from -proposed
- check that you can still discuss and use empathy functions to interact with your friends

could somebody confirm their msn is still working in empathy with the new telepathy-butterfly version so it can go to updates?

No regression for me with butterfly 0.5.11 in Lucid.

The version in proposed works fine for me too, and the bug is fixed.

This bug was fixed in the package telepathy-butterfly - 0.5.11-0ubuntu1

---------------
telepathy-butterfly (0.5.11-0ubuntu1) lucid-proposed; urgency=low

  * New upstream bug fix versions:
    Fixes:
    - fd.o#28354: make sure the correct type gets returned when getting
      PendingMessages.
    - Don't always remove pending messages when ListPendingMessages is called.
    - Don't assume "message-type" is set on calls to SendMessage.
    - Replace \r\n with \n in incoming messages. (lp: #546338)
    Enhancements:
    - Implement friendly names for groups chats
    Fixes:
    - Fix error when getting caps for certain contacts and offline contacts
    - Remove deprecation warning at start (lp: #570346)
    - Set Initator{ID,Handle} for all channels types
    - Don't connect via HTTP if we lost connection (lp: #430768)
    - Fix crash in check_handle when adding a contact (lp: #512596)
 -- Sebastien Bacher <email address hidden> Tue, 08 Jun 2010 18:41:38 +0200

Accepted empathy into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

I've been using the package for more than a day already and did not noticed any regression yet, Though i cannot reproduce the original bug report (newlines one). MSN and Google talk are still working fine here. Thanks all.

This bug was fixed in the package empathy - 2.30.1.1-0ubuntu1

---------------
empathy (2.30.1.1-0ubuntu1) lucid-proposed; urgency=low

  * New upstream release:
    - empathy_dispatcher_join_muc: assertion failed: (connection_data != NULL)
      when joining favorites rooms while account is connecting
      (Guillaume Desmottes)
     - Possible to open multiple accounts dialog (Danielle Madeley)
     - Fixed build failure due to missing header (Jasper Lievisse
       Adriaanse)
     - Empathy accounts CC module calls textdomain (Rob Bradford)
     - Should call gtk_builder_set_translation_domain on GtkBuilder
       UI components (Rob Bradford)
     - Empathy silently fails importing contacts from Pidgin
       (Guillaume Desmottes) (LP: #550569)
     - Empathy should use port 8001 to connect to freenode irc (Brian Curtis)
       (LP: #568901)
     - IRC account: don't allow to save changes when editing network
       details (Guillaume Desmottes)
     - Incomplete localisation of g-c-c module (Rob Bradford)
     - Avatar chooser can enter infinite loop (Xavier Claessens)
     - configure script not compatible with dash as /bin/sh (Simon McVittie)
     - crash on 0-byte file in log search (Robert McQueen)
     - "Network error" on connecting to Facebook Chat (Guillaume Desmottes)
       (LP: #542836)
     - "Previous Conversations" Search entry is not activatable
       (Guillaume Desmottes)
     - empathy hangs with high cpu load when changing avatar (Xavier
       Claessens)
     - "Join favorites" should deal better with connecting accounts
       (Guillaume Desmottes)
     - Status reported by account dialog is wrong in connman mode
       (Rob Bradford)
     - accounts_dialog_update_status_infobar mixes const and
       allocated strings for message (Rob Bradford)
     - Empathy should not requires that geoclue providers support
       updates (Laurent Bigonville)
     - some messages get dropped when using adium themes (Guillaume
       Desmottes) (LP: #546338)
     - empathy does not set geoclue requirements before asking for
       address/position (Laurent Bigonville)
     - Missing image icon shows up when contact has no avatar
       (Frédéric Péters)
     - Crash when trying to start a camera preview without a camera
       (Sjoerd Simons)
    - updated translations
  * added debian/patches/90_revert_removal_stock_person.patch:
    remove upstream git commit b87a2f274a838e8636c64605506e6ba243c2671a
    ad we don't have gnome-icon-theme 2.30
 -- Didier Roche <email address hidden> Tue, 15 Jun 2010 09:30:00 +0200