warn when committing large (binary) files

It could be nice to at least warn, so that people don't commit their large ISO image accidentally. (Or commit their .obj, .pch, etc files)

Hi, Shannon, thanks for your interest in this. If you want to talk
about how to do it, feel very free to ask here or on irc, and also to
put up a branch for review even before you're totally sure it's the
right fix.

Basically, you probably want a check inside the commit builder at the
time it's storing an individual file and to raise a warning through
the ui_factory. Secondary issues:

 * should be configurable as far as size or turning it off altogether?
 * one warning per file?
 * need to test it, probably by turning the configured size down very
low so that we don't actually need to commit a huge file.

hth, don't hesitate to ask.

Martin

Thanks Martin. I'm just starting to orient to the codebase, so certainly all pointers are appreciated.

If it's done in the commit builder, does this mean the "add" operation would succeed silently, and it would only warn during commit? From a user perspective, I think I'd want the warning at add time.

I'm also wondering exactly what action it takes when it finds the large file(s). Should it refuse to add it, and require a command line option to force (as in the original description above)? Or should it merely warn that you've added it? And is this only checked for binary files?

I think having a configurable size threshold makes sense, and perhaps setting it to 0 can turn it off.

Agreed on the test plan.

Shannon

I've pushed a first cut of this. Comments welcome.

bOn Fri, 2011-08-05 at 21:02 +0000, Shannon Weyrick wrote:
> I've pushed a first cut of this. Comments welcome.

> ** Branch linked: lp:~weyrick/bzr/54624-warn-on-large-files
Can you perhaps create a merge proposal for this branch against lp:bzr?

Cheers,

Jelmer

Yes, proposed. Thanks.
Shannon

  status fixreleased

We use fixreleased for branches that have landed in bzr.

Thanks for your work on this!