apport still uses the "beta" LP API

Bug #545009 reported by Michael Bienia
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Apport
Fix Released
Undecided
Martin Pitt
apport (Ubuntu)
Fix Released
High
Martin Pitt
Lucid
Fix Released
High
Martin Pitt

Bug Description

The currently used LP API version is still "beta" but "1.0" got released in March 2010. According to https://edge.launchpad.net/+apidoc/ the "beta" API is only supported till April 2011 (EOL of karmic) while "1.0" stays till April 2015 (EOL of lucid).
So it would be good if apport used (or at least supported) the "1.0" API to avoid any patching during the lucid lifetime.

The main difference between the "beta" and "1.0" API is the removal of mutator methods where write-access to attributes exist (e.g. the transitionTo... methods).

Revision history for this message
Michael Bienia (geser) wrote :

Here is an untested diff. It forces the use of the "1.0" API (default is still "beta" but as I've be told this is expected to be change for lucid) and replaces the "transitionTo..." calls with setting the attribute directly and calling lp_save() on the object.

Changed in apport:
assignee: nobody → Martin Pitt (pitti)
Revision history for this message
Martin Pitt (pitti) wrote :

Thanks! I talked to the LP guys today, and they will fix staging soon, so that the test suite will work again. Then this is much easier to test.

Changed in apport:
status: New → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

This is currently blocked by bug 551704.

Changed in apport:
status: In Progress → Triaged
Revision history for this message
Martin Pitt (pitti) wrote :

OK, bug 551704 has an easy workaround.

Changed in apport:
status: Triaged → In Progress
Revision history for this message
Martin Pitt (pitti) wrote :

trunk r1746

Changed in apport:
status: In Progress → Fix Released
Revision history for this message
Martin Pitt (pitti) wrote :

Setting to "High", because the beta API is going to be deprecated within lucid's timeframe.

Changed in apport (Ubuntu):
assignee: nobody → Martin Pitt (pitti)
importance: Undecided → High
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package apport - 1.13.2-0ubuntu1

---------------
apport (1.13.2-0ubuntu1) lucid; urgency=low

  [ Martin Pitt ]
  * New upstream bug fix release:
    - packaging-apt-dpkg.py, _install_debug_kernel(): Do not crash on an
      outdated kernel, just return that it is outdated. (LP: #532923)
    - launchpad.py test suite: Add "Referer" HTTP header, now required by
      launchpad.
    - launchpad.py: Fix crash if configuration does not have an
      "escalated_tag" option.
    - launchpad.py: Port to launchpadlib 1.0 API, thanks Michael Bienia for
      the initial patch! (LP: #545009)
    - gtk/apport-gtk-mime.desktop.in, kde/apport-kde-mime.desktop.in: Change
      categories so that these do not ever appear in menu editors.
      (LP: #449215)
    - launchpad.py: Some LP bugs have broken attachments (this is a bug in
      Launchpad itself). Ignore those instead of crashing.
    - apport-gtk: Turn http:// and https:// links into clickable hyperlinks in
      information and error dialogs. (LP: #516323)
    - apport-retrace: Fix crash when trying to rebuild package info for
      reports without an ExecutablePath. (LP: #436157)
    - ui.py: Fix crash when package information cannot be determined due to
      broken apt status. (LP: #362743)
    - ui.py: Fix crash when /etc/apport/crashdb.conf is damaged; print an
      appropriate error message instead. (LP: #528327)
    - data/kernel_crashdump: Fix crash if log file disappeared underneath us.
      (LP: #510327)
    - data/apport: Fix IOError when apport is called with invalid number of
      arguments, and stderr is not a valid fd. (LP: #467363)
    - hookutils.py: Factor out the DMI collection code from attach_hardware()
      into attach_dmi(), and call that in attach_alsa() as well. Thanks to
      Brad Figg for the patch! (LP: #552091)
    - apport/ui.py: Fix the help output if Apport is invoked under an
      alternative name (like apport-collect). (LP: #539427)
  * debian/local/apport-chroot: Fix crash if $APPORT_CRASHDB_CONF is not set.
    (LP: #487700)
  * debian/control: Bump python-launchpadlib dependency, to ensure that we
    have a current version (LP: #407091), and the "1.0" protocol available.
  * data/package-hooks/source_linux.py: Drop _() i18n, it's not available in
    the hook and causes crashes. (LP: #538368)

  [ Leann Ogasawara ]
  * data/package-hooks/source_linux.py:
    - Clean up some of the wording in the information dialogs for the
      interactive kernel hook. Also add an additional "I don't know" option when
      asked how frequently an issue occurs. (LP: #534638)
    - Autodetect if running an upstream kernel. (LP: #532932)
    - Attempt to categorize issue. Then add tag based on category.
      (LP: #534745)
 -- Martin Pitt <email address hidden> Wed, 31 Mar 2010 16:32:39 +0200

Changed in apport (Ubuntu Lucid):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.