SVN Commit throws 'SvnBranch' object has no attribute 'control_files'

Bug #540363 reported by Justin Shepard
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
QBzr
Fix Released
High
Alexander Belchenko

Bug Description

This error appears after a successful commit to an SVN repository via HTTP:
Using Windows XP Pro SP4, installed bzr 2.1.0.2 via "standalone installer" w/default options (except removed 'developer documentation').

bzr: ERROR: exceptions.AttributeError: 'SvnBranch' object has no attribute 'control_files'

Traceback (most recent call last):
  File "C:/Program Files/Bazaar/plugins\qbzr\lib\commit.py", line 685, in closeEvent
  File "C:/Program Files/Bazaar/plugins\qbzr\lib\commit.py", line 680, in _save_or_wipe_commit_data
  File "C:/Program Files/Bazaar/plugins\qbzr\lib\commit.py", line 573, in wipe_commit_data
AttributeError: 'SvnBranch' object has no attribute 'control_files'

bzr 2.1.0 on python 2.5.4 (win32)
arguments: ['C:\\Program Files\\Bazaar\\bzr.exe', 'qcommit', '--ui-mode']
encoding: 'cp1252', fsenc: 'mbcs', lang: None
plugins:
  bzrtools C:\Program Files\Bazaar\plugins\bzrtools [2.1.0]
  explorer C:\Program Files\Bazaar\plugins\explorer [1.0.1]
  launchpad C:\Program Files\Bazaar\plugins\launchpad [2.1.0]
  netrc_credential_store C:\Program Files\Bazaar\plugins\netrc_credential_store [2.1.0]
  news_merge C:\Program Files\Bazaar\plugins\news_merge [2.1.0]
  qbzr C:\Program Files\Bazaar\plugins\qbzr [0.18.3]
  rebase C:\Program Files\Bazaar\plugins\rebase [0.5.5]
  svn C:\Program Files\Bazaar\plugins\svn [1.0.2]
  upload C:\Program Files\Bazaar\plugins\upload [1.0.0dev]
  xmloutput C:\Program Files\Bazaar\plugins\xmloutput [0.8.6]

Related branches

Revision history for this message
Alexander Belchenko (bialix) wrote :

So, you're committing directly into svn from bzr, right?

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

control_files really should be private and not used by e.g. qbzr.

Revision history for this message
Jelmer Vernooij (jelmer) wrote :

Branch.get_physical_lock_status() also exists, perhaps qbzr can use that instead?

Revision history for this message
Alexander Belchenko (bialix) wrote :

Jelmer, thanks for the hints.

Changed in qbzr:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Alexander Belchenko (bialix)
milestone: none → 0.18.4
Revision history for this message
Alexander Belchenko (bialix) wrote :

Justin, please test the revision 1226 from lp:qbzr/0.18 branch, and re-open this bug if there is still problems.

Changed in qbzr:
status: Confirmed → Fix Released
Revision history for this message
Justin Shepard (jshepard) wrote :

Alexander, I do not have a build environment to build the entire branch, but i did pull the updated commit.py from the repository and copied it to my application directory -- it seems to have fixed the problem. I'm very impressed with the quick turnaround on this! :)

Revision history for this message
Alexander Belchenko (bialix) wrote :

Thanks for the testing.

Re quick turnaround: I'm trying to fix easy bugs as fast as possible. Fortunately this one was the easy bug :-) You're lucky.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.