Launchpad itself

Radio button for new translation input field no longer selected when typing a new translation

Bug #540105 reported by David Planella
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Adi Roiban
Launchpad itself 10.03

Bug Description

I noticed this behaviour in edge:

When entering text in the input box for a translation, this textbox does no longer get the focus by automatically selecting the checkbox dot on its left.

This leads to translators not noticing it, pressing "Save" and loosing all their translations.

Related branches

lp:~adiroiban/launchpad/bug-540105
Edwin Grubbs (community): Approve (code)
Diff: 338 lines (+152/-55)
5 files modified
lib/canonical/launchpad/javascript/translations/pofile.js (+54/-40)
lib/lp/app/templates/base-layout-macros.pt (+3/-0)
lib/lp/translations/templates/pofile-translate.pt (+26/-8)
lib/lp/translations/templates/translationmessage-translate.pt (+17/-7)
lib/lp/translations/windmill/tests/test_pofile_translate.py (+52/-0)
Revision history for this message
Henning Eggers (henninge) wrote :

Currently this regression only happens on edge, staging is still ok. Output of "on-edge -v":

edge is running stable r10529.
edge has newer revisions than stable.
staging is running db-stable r9111.
r9112:
[rs=buildbot-poller] automatic merge from stable. Revisions: 10510
 included.
r9111:
[rs=buildbot-poller] automatic merge from stable. Revisions: 10508,
 10509 included.
Last automatic merge on db-stable r9112 was stable r10510.

So the regression must have happened between r10509 and r10529 of devel.

Changed in rosetta:
importance: Undecided → High
status: New → Triaged
Revision history for this message
Данило Шеган (danilo) wrote :

I've confirmed that this was introduced by r10525: [r=gmb][ui=none][bug=359180,513625] Add keybindings on translating pofiles or translation messages. Adi, can you please take a look at what's involved in fixing JS here?

Changed in rosetta:
assignee: nobody → Adi Roiban (adiroiban)
milestone: none → 10.03
Revision history for this message
Adi Roiban (adiroiban) wrote :

The problem was in pofile.js updateNotificationBox(). This function was failing before, but it was ran in a different sandbox.

I had fixed the updateNotificationBox() function and moved each independent functionality in a separate sandbox.

I have opened bug 540216 to look into how we can improve the JS tests for +translate pages.

Changed in rosetta:
status: Triaged → In Progress
Revision history for this message
Данило Шеган (danilo) wrote :

Thanks, Adi.

Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r10559 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10559>

Changed in rosetta:
status: In Progress → Fix Committed
tags: added: qa-needstesting
Adi Roiban (adiroiban)
tags: added: qa-ok
removed: qa-needstesting
Adi Roiban (adiroiban)
summary: - Text input box no longer gaining focus in edge
+ Radio button for new translation input field no longer selected when
+ typing a new translation
Revision history for this message
Curtis Hovey (sinzui) wrote : Bug 540105 Fix released

Fixed released in launchpad-project 10.03.

Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.