pitivi crashed with TypeError in do_simple_paint()

In my case, I can randomly reproduce it by making (or loading) a project with a bunch of clips on the timeline, hitting the spacebar to play/pause clips, and then sometimes pitivi doesn't react and apport pops up.

Got a traceback :
File "/usr/lib/pitivi/python/pitivi/ui/curve.py", line 261, in do_simple_paint
cr.reset_clip()
TypeError: Required argument 'cr' (pos 1) not found

After some investigation, this looks like a bug in pycairo.

I can reproduce this bug outside of Pitivi. This looks like a subtlety/bug in pygtk!

In pygtk02.17.0/gtk/gdkcairo.override, lines 128 to 144, the wrapper requests keyword arguments "cr" and "drawable". Most other wrappers seem not to use the "cr" arguments, but retrieve the cairo context by using PycairoContext_GET(self). Maybe we just want to push this upstream and ask the pygtk developers what was their idea... In any case, gtk.gdk.CairoContext.reset_clip is undocumented.

A solution (or workaround, depending on how we perceive this) would be to replace

    cr.reset_clip()

with

    cr.reset_clip(cr=cr, drawable=self.get_canvas())

I reported the bug in upstream pycairo. Argh, I hadn't seen you patched
pitivi for this in ubuntu. But I guess having upstream's opinion on this
is better, so we know if the patch is legitimate or not and if it should
be applied to pitivi git.

Upstream has a different fix. I need some help testing this. Can someone who can easily reproduce this problem test with emdash's "simple_paint_bug_612501" branch? The specific commit is this one: http://github.com/emdash/pitivi/commit/6981c2f22cfc1ae4308804c08a116a4e22fed1fd

I tried testing, but even with vanilla pitivi git (which is supposed to trigger the bug), I'm not able to trigger the bug at all. I'd like someone to confirm beyond the placebo effect.

This bug was fixed in the package pitivi - 0.13.4-0ubuntu2

---------------
pitivi (0.13.4-0ubuntu2) lucid; urgency=low

  * debian/patches/lp537619_gdk_cairo_reset_clip.patch: Use correct
    parameters for gtk.gdk.CairoContext.reset_clip. (LP: #537619)
 -- Philippe Gauthier <email address hidden> Mon, 05 Apr 2010 17:10:22 -0400

Still got the error with package 0.13.4-0ubuntu3
See https://bugs.launchpad.net/pitivi/+bug/537619/comments/2 for how to reproduce it

Yann: except that I (the one who wrote comment #2) am now unable to reproduce it. You have to provide better instructions than mine, also see comment #8.

This bug report should be closed. PiTIVi has the fix and it's not pycairo's problem (see pycairo bug report)

Philippe Gauthier, please revert the patch you applied to the ubuntu package and apply the official fix from upstream. Your patch is causing other issues and makes triaging harder because they are ubuntu-specific...

Oh and I meant the *pitivi* package in ubuntu. Thanks :)

still present in pitivi 0.13.4-2ubuntu1 in maverick

Please try with the 0.13.4.2 pre-release available today in the GStreamer PPA. The Ubuntu package is still incorrectly patched. If this fixes your issues, Ubuntu needs to revert its patch/package the upcoming pitivi release.

Hello,

the failure still presents with pitivi 0.13.5-1~lucid1 in lucid.
I used the "PPA for GStreamer developers"
deb http://ppa.launchpad.net/gstreamer-developers/ppa/ubuntu lucid main
deb-src http://ppa.launchpad.net/gstreamer-developers/ppa/ubuntu lucid main

I also updated the other depending packages.

Can you try the package in maverick-proposed? I'm thinking this is a side-effect of bug #640630.

Ok I try

Thank you

Le dimanche 17 octobre 2010 à 16:18 +0000, Jean-François Fortin Tam a
écrit :
> Can you try the package in maverick-proposed? I'm thinking this is a
> side-effect of bug #640630.
>

Au fait je suis français.

Le dimanche 17 octobre 2010 à 16:18 +0000, Jean-François Fortin Tam a
écrit :
> Can you try the package in maverick-proposed? I'm thinking this is a
> side-effect of bug #640630.
>

0.93 is now available in Ubuntu 14.04's proposed updates, which makes the issue obsolete.