Portability: Hardcoded reference to /bin/bash in byobu-config

Bug #535407 reported by ermo | Rune Morling
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
byobu
Fix Released
Wishlist
Unassigned
byobu (Ubuntu)
Fix Released
Wishlist
Dustin Kirkland 

Bug Description

Dustin,

As you so politely suggested, here is a new bug for the hardcoded reference to /bin/bash in byobu-config:

<ermo@mrwing>:[~/conary/builds/byobu/byobu-2.62]
(127)$ grep -C2 -n bash /usr/bin/byobu-config
184-
185-def newwindow(screen, size):
186: title=Entry(8, text="bash", returnExit=1)
187- titlel=Label(_("Title: "))
188: command=Entry(20, text="/bin/bash", returnExit=1)
189- commandl=Label(_("Command: "))
190-

On my system, /bin/bash is the default shell and $BASH is "/bin/bash", so that would be one way to obtain the full path to bash in a slightly more portable manner. But on systems where bash is installed but not the default shell and may not even be installed under /bin, another approach would likely be needed?

UPDATE: Ok, tried the functionality and noticed that the hardcoded aspect is not a problem per se, so this should probably be a feature request instead of a bug.

If it is implemented, byobu would intelligently fetch the full path to the local bash interpreter and update the command field and that would be it.

Related branches

description: updated
Changed in byobu:
status: New → Fix Committed
importance: Undecided → Wishlist
Changed in byobu (Ubuntu):
status: New → Fix Committed
importance: Undecided → Wishlist
assignee: nobody → Dustin Kirkland (kirkland)
Changed in byobu:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package byobu - 2.63-0ubuntu1

---------------
byobu (2.63-0ubuntu1) lucid; urgency=low

  [ Dustin Kirkland ]
  * etc/byobu/socketdir, usr/bin/byobu-config, usr/bin/byobu-janitor,
    usr/bin/byobu-select-profile: increase portability to other distros,
    create socketdir conffile and SOCKETDIR variable for users who don't
    use /var/run/screen as the socket directory, LP: #535378
  * usr/bin/byobu-config: change a sample reference from "bash" to "shell"
    again for portability, LP: #535407
  * bin/byobu-export, bin/byobu-reconnect-sockets, bin/byobu-status,
    lib/byobu/cpu_temp: avoid programmatic use of ls in for loops,
    LP: #452405

  [ Torsten Spindler ]
  * debian/postinst: handle situation where /var/run/screen does not
    exist, LP: #535648
 -- Dustin Kirkland <email address hidden> Tue, 09 Mar 2010 14:53:10 -0600

Changed in byobu (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.