Launchpad itself

recent custom uploads changes broke debian-installer uploads

Bug #535383 reported by Colin Watson
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Critical
William Grant
Launchpad itself 10.03

Bug Description

Every binary upload of debian-installer is now failing:

2010-03-09 21:03:59 DEBUG Publishing build to ubuntu/lucid/sparc
2010-03-09 21:03:59 DEBUG ... debian-installer/20081029ubuntu89 (Arch Specific)
2010-03-09 21:03:59 DEBUG Publishing custom debian-installer, debian-installer_20081029ubuntu89_sparc_translations.tar.gz, debian-installer-images_20081029ubuntu89_sparc.tar.gz to ubuntu/lucid
2010-03-09 21:04:00 DEBUG Publishing custom debian-installer, debian-installer_20081029ubuntu89_sparc_translations.tar.gz, debian-installer-images_20081029ubuntu89_sparc.tar.gz to ubuntu/lucid
2010-03-09 21:04:02 ERROR Queue item ignored: Tarfile /tmp/tmp5_yfME/debian-installer-images_20081029ubuntu89_sparc.tar.gz has a file ./ which is illegal
2010-03-09 21:04:02 DEBUG Publishing build to ubuntu/lucid/ia64
2010-03-09 21:04:02 DEBUG ... debian-installer/20081029ubuntu89 (Arch Specific)
2010-03-09 21:04:02 DEBUG Publishing custom debian-installer, debian-installer_20081029ubuntu89_ia64_translations.tar.gz, debian-installer-images_20081029ubuntu89_ia64.tar.gz to ubuntu/lucid
2010-03-09 21:04:03 DEBUG Publishing custom debian-installer, debian-installer_20081029ubuntu89_ia64_translations.tar.gz, debian-installer-images_20081029ubuntu89_ia64.tar.gz to ubuntu/lucid
2010-03-09 21:04:05 ERROR Queue item ignored: Tarfile /tmp/tmp2DuKOq/debian-installer-images_20081029ubuntu89_ia64.tar.gz has a file ./ which is illegal
2010-03-09 21:04:06 DEBUG Publishing build to ubuntu/lucid/armel
2010-03-09 21:04:06 DEBUG ... debian-installer/20081029ubuntu89 (Arch Specific)
2010-03-09 21:04:06 DEBUG Publishing custom debian-installer, debian-installer_20081029ubuntu89_armel_translations.tar.gz, debian-installer-images_20081029ubuntu89_armel.tar.gz to ubuntu/lucid
2010-03-09 21:04:06 DEBUG Publishing custom debian-installer, debian-installer_20081029ubuntu89_armel_translations.tar.gz, debian-installer-images_20081029ubuntu89_armel.tar.gz to ubuntu/lucid
2010-03-09 21:04:08 ERROR Queue item ignored: Tarfile /tmp/tmp5_lEjR/debian-installer-images_20081029ubuntu89_armel.tar.gz has a file ./ which is illegal
2010-03-09 21:04:09 DEBUG Publishing build to ubuntu/lucid/amd64
2010-03-09 21:04:09 DEBUG ... debian-installer/20081029ubuntu89 (Arch Specific)
2010-03-09 21:04:09 DEBUG Publishing custom debian-installer, debian-installer_20081029ubuntu89_amd64_translations.tar.gz, debian-installer-images_20081029ubuntu89_amd64.tar.gz to ubuntu/lucid
2010-03-09 21:04:09 DEBUG Publishing custom debian-installer, debian-installer_20081029ubuntu89_amd64_translations.tar.gz, debian-installer-images_20081029ubuntu89_amd64.tar.gz to ubuntu/lucid
2010-03-09 21:04:12 ERROR Queue item ignored: Tarfile /tmp/tmp25KWck/debian-installer-images_20081029ubuntu89_amd64.tar.gz has a file ./ which is illegal
2010-03-09 21:04:12 DEBUG Publishing build to ubuntu/lucid/i386
2010-03-09 21:04:12 DEBUG ... debian-installer/20081029ubuntu89 (Arch Specific)
2010-03-09 21:04:12 DEBUG Publishing custom debian-installer, debian-installer_20081029ubuntu89_i386_translations.tar.gz, debian-installer-images_20081029ubuntu89_i386.tar.gz to ubuntu/lucid
2010-03-09 21:04:13 DEBUG Publishing custom debian-installer, debian-installer_20081029ubuntu89_i386_translations.tar.gz, debian-installer-images_20081029ubuntu89_i386.tar.gz to ubuntu/lucid
2010-03-09 21:04:15 ERROR Queue item ignored: Tarfile /tmp/tmprRexdV/debian-installer-images_20081029ubuntu89_i386.tar.gz has a file ./ which is illegal

A tarfile entry "./" is harmless and should be ignored - it's just the root of the filesystem tree in the tarball.

Could this please be fixed as a matter of urgency? We cannot build Lucid alternate or server images until this is fixed, and beta freeze is in two days.

Tags: lp-soyuz qa-ok

Related branches

lp:~wgrant/launchpad/fix-custom-uploads-with-root-dirs
Björn Tillenius (community): Abstain
Julian Edwards (community): Approve
Diff: 61 lines (+20/-3)
2 files modified
lib/lp/archivepublisher/customupload.py (+13/-3)
lib/lp/archivepublisher/tests/test_customupload.py (+7/-0)
Revision history for this message
James Troup (elmo) wrote :

LOSAs, when the soyuz folks have a patch for this, please help expedite a fix by cowboy patching it onto cocoplum.

Revision history for this message
Colin Watson (cjwatson) wrote :

I think you want something along the lines of the attached patch, although I have not tested this and there may be a more elegant way to do it.

Revision history for this message
James Troup (elmo) wrote :

Given a) the timing of all of this b) the fact that the patch is restricted to the custom upload processor which is broken as is, c) ack from the Ubuntu Release Manager, I've taken the liberty of applying wgrant's 10460 onto cocoplum. I'll update LPS.

Revision history for this message
William Grant (wgrant) wrote :

The in-progress publisher run has successfully processed those tarballs -- everything should be fixed now.

Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r10478 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10478>

Changed in soyuz:
assignee: nobody → William Grant (wgrant)
milestone: none → 10.03
status: New → Fix Committed
tags: added: qa-needstesting
Julian Edwards (julian-edwards)
Changed in soyuz:
status: Fix Committed → Fix Released
importance: Undecided → Critical
tags: added: qa-ok
removed: qa-needstesting
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.