Launchpad itself

patches portlet should appear above attachment portlet

Bug #534736 reported by Brian Murray
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Karl Fogel
Launchpad itself 10.03

Bug Description

Ubuntu bug reports can frequently receive lots of attachments. In the even one of these bug report has a patch you may have to scroll through several screens of attachments to the find the patches portlet. I think it would be more useful to have patches appear above attachments.

Related branches

lp:~kfogel/launchpad/534736-patches-portlet-first
Abel Deuring (community): Approve (code)
Diff: 87 lines (+42/-22)
2 files modified
lib/lp/bugs/stories/bugattachments/xx-attachments-to-bug-report.txt (+20/-0)
lib/lp/bugs/templates/bug-portlet-attachments.pt (+22/-22)
Deryck Hodge (deryck)
Changed in malone:
status: New → Triaged
importance: Undecided → High
tags: added: trivial ui
Karl Fogel (kfogel)
Changed in malone:
assignee: nobody → Karl Fogel (kfogel)
status: Triaged → In Progress
milestone: none → 10.03
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit

Fixed in stable r10527 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/10527>

Changed in malone:
status: In Progress → Fix Committed
tags: added: qa-needstesting
Revision history for this message
Karl Fogel (kfogel) wrote :

QA'd by finding bug #534667, which has both patches and non-patch attachments, and seeing that the patches show first.

Note: kind of makes me realize that maybe the subscribers portlet should come after attachments... but that's a separate issue TBD.

tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Brian Murray (brian-murray) wrote :

Karl - actually I prefer that at least direct subscribers appear above patches as this is rather important for Ubuntu bug workflows.

This looks great by the way - thanks!

Revision history for this message
Karl Fogel (kfogel) wrote :

Brian, thanks. I think the best course is probably not to do anything about it until someone says "I can't see the patches" or something, anyway. It's just when the subscribers or "also notified" list is really long, it takes up a lot of real estate. There are other possible solutions: contractable list, etc. Just thinking out loud.

Revision history for this message
Jonathan Lange (jml) wrote : Re: [Bug 534736] Re: patches portlet should appear above attachment portlet

On Wed, Mar 17, 2010 at 4:39 PM, Karl Fogel <email address hidden> wrote:
> Brian, thanks.  I think the best course is probably not to do anything
> about it until someone says "I can't see the patches" or something,
> anyway.  It's just when the subscribers or "also notified" list is
> really long, it takes up a lot of real estate.  There are other possible
> solutions: contractable list, etc.  Just thinking out loud.

I agree with this course of action. However, I'm keen to know what
kind of workflows require looking at the subscriber list. Separate
discussion, I guess.

jml

Karl Fogel (kfogel)
Changed in malone:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.