record last_revision used to determine partial success before doing import

Bug #532402 reported by Michael Hudson-Doyle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Michael Hudson-Doyle

Bug Description

To determine whether a code import got all the revisions in a branch or stopped early because of a revision limit, we do roughly this:

doImport(source, target)
partial = target.last_revision() == source.last_revision()

However, if the import takes several hours, as it does sometimes, it's moderately likely that the last_revision of the source has now changed, which will give rise to an (essentially) spurious result of partially successful.

Cheers,
mwh

Related branches

Changed in launchpad-code:
status: Triaged → In Progress
Revision history for this message
Ursula Junque (ursinha) wrote : Bug fixed by a commit
Changed in launchpad-code:
status: In Progress → Fix Committed
tags: added: qa-needstesting
Tim Penhey (thumper)
tags: added: qa-ok
removed: qa-needstesting
Tim Penhey (thumper)
Changed in launchpad-code:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.