Fonts are very small with adium theme

Bug #531835 reported by Omer Akram
80
This bug affects 14 people
Affects Status Importance Assigned to Milestone
Adium Theme Ubuntu
Fix Released
Undecided
Ken VanDine
Empathy
Invalid
Undecided
Unassigned
adium-theme-ubuntu (Ubuntu)
Fix Released
Low
Ken VanDine
Lucid
Invalid
Undecided
Unassigned
empathy (Ubuntu)
Fix Released
Low
Unassigned
Lucid
Fix Released
Wishlist
Unassigned

Bug Description

Binary package hint: adium-theme-ubuntu

When using this theme fonts look very small. the same theme's fonts look fine in gwibber.

Revision history for this message
Omer Akram (om26er) wrote :

small fonts

Revision history for this message
Omer Akram (om26er) wrote :

using same theme in gwibber, fonts are fine

Changed in empathy (Ubuntu):
importance: Undecided → Low
status: New → Triaged
Changed in adium-theme-ubuntu (Ubuntu):
assignee: nobody → Ken VanDine (ken-vandine)
Revision history for this message
Omer Akram (om26er) wrote :

Ken can you please look into this. the chat fonts look very small and changing the font size in theme's config file had no effect

Revision history for this message
Ken VanDine (ken-vandine) wrote :

I suspect this is an upstream empathy bug, perhaps empathy just doesn't handle over-riding the font sizes in webkit based on desktop settings. Gwibber does do that, but it isn't really theme related as far as I know.

Revision history for this message
Omer Akram (om26er) wrote :

I have open an upstream empathy task for this.

Revision history for this message
Omer Akram (om26er) wrote :
Changed in empathy:
importance: Unknown → Undecided
status: Unknown → New
status: New → Invalid
Changed in adium-theme-ubuntu (Ubuntu):
status: New → Confirmed
Changed in empathy (Ubuntu):
status: Triaged → Confirmed
Revision history for this message
Omer Akram (om26er) wrote :

Patch from Jamie Strandboge

tags: added: patch
Revision history for this message
nomnex (nomnex) wrote :

omer, regarding patches on Launchpad.
a. do we apply them ourselves?
b. they are available on the back port repository (e.g. empathy 2.30.x patched)?

Revision history for this message
Ken VanDine (ken-vandine) wrote :

Thanks for the patch, however I think it would be better to fix empathy to handle setting the font based on the system settings. Font choice and size is pretty subjective, so honoring the system setting for document font would be best.

Revision history for this message
Ken VanDine (ken-vandine) wrote :

To expand on that, I think the adium theme should be modified removing references to the font from main.css and empathy/webkit should use the system document font by default and allow the theme to override that in the css.

Revision history for this message
Omer Akram (om26er) wrote :

Ken, Can we get this into Lucid with SRU. the settings with this patch are much better than the font size we have already.

Revision history for this message
Ken VanDine (ken-vandine) wrote :

The problem is I think that is rather subjective, for me the current fonts look much better. Choosing the proper font size is going to vary based on screen size/resolution and individual opinion. Which is why I think this is best fixed in empathy to honor system preferences.

Revision history for this message
Jordi R (jordi1983) wrote :

I've made a patch to fix the font size bug.

What it does it to remove the DefaultFontFamily and DefaultFontSize keys from Info.plist file, also removes the font-size:11px from the Contents/Resources/main.css at line 111.

So now the font displayed is the system font.

Revision history for this message
Omer Akram (om26er) wrote :

Not an empathy issue

Changed in empathy (Ubuntu):
status: Confirmed → Invalid
Revision history for this message
Omer Akram (om26er) wrote :

I have build the adium theme with your patch (took 46hours to build though) and the chat text now depends on the system fonts. https://edge.launchpad.net/~om26er/+archive/test Now the other problem is that the text of the sender/receiver is still very small and does not change at all with font changes. Marking triaged for now we will address this issue for Maverick.

Changed in adium-theme-ubuntu (Ubuntu):
importance: Undecided → Low
status: Confirmed → Triaged
Revision history for this message
Nigel Babu (nigelbabu) wrote :

Based on Omer's last comment, I feel this patch is not quite ready yet, adding patch-needswork tag.

tags: added: patch-needswork
removed: patch
Revision history for this message
innervision (dguaraglia) wrote :

I think Jordi's patch is the only one that makes sense. Hard-coding *any* font family/size would only move the problem somewhere else (I can already picture people using low-resolution netbooks complaining about the font being too big).

Revision history for this message
Omer Akram (om26er) wrote :

here the the patched theme with Jordi's patch https://launchpad.net/~om26er/+archive/test/+build/1712973/+files/adium-theme-ubuntu_0.1-0ubuntu2_all.deb The chat fonts are perfect but the text names of the send/receiver and also the text of the timestamps is very small. But the thing that really matters is the chat fonts so Yeah the patch pretty much does the trick :)

Revision history for this message
Omer Akram (om26er) wrote :

Sorry for all the spamming. Here is a patch which also changes the size of timestamps and also the sender/receivers names to the system fonts.

Revision history for this message
Omer Akram (om26er) wrote :

Also made a .deb with the changes implemented. (launchpad builders take a lot of time these days).

Revision history for this message
Miroslav Hadzhiev (xtigyro) wrote :

Yes, this new adium theme package solved the problem here. (:

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package adium-theme-ubuntu - 0.2-0ubuntu1

---------------
adium-theme-ubuntu (0.2-0ubuntu1) maverick; urgency=low

  * New upstream release.
    - Don't hard code font sizes (Omer Akram) (LP: #531835)
 -- Ken VanDine <email address hidden> Wed, 09 Jun 2010 14:36:38 -0400

Changed in adium-theme-ubuntu (Ubuntu):
status: Triaged → Fix Released
Changed in adium-theme-ubuntu:
assignee: nobody → Ken VanDine (ken-vandine)
status: New → Fix Released
Revision history for this message
Andrew Cowie (afcowie) wrote :

Can we get this backported to Lucid please?

AfC

Revision history for this message
Xavier Claessens (zdra) wrote :

Note that empathy uses the application font as fallback for adium themes, not the document font. There is an upstream bug for this with a patch: https://bugzilla.gnome.org/show_bug.cgi?id=622266

Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :

uploaded to -proposed:

empathy (2.30.2-0ubuntu1) lucid-proposed; urgency=low

  * New upstream release:
    - empathy-2.30.1.1: tests fail (Guillaume Desmottes)
    - crash when closing chat with still-open notification bubble
      (Guillaume Desmottes)
    - Can't connect chatroom if space after adress (Guillaume Desmottes)
    - Updated translations
  * debian/patches/32_append_notifications.patch:
    - refresh to new version
  * debian/patches/91_git_fix_small_font.patch:
    - take document font for adium theme to fix small fonts (LP: #531835)

test case:
- install the new version from -proposed
- test that you still can chat with your contacts on different networks
- check that font size is more readable than previous version

Changed in empathy (Ubuntu):
status: Invalid → Triaged
Changed in empathy (Ubuntu Lucid):
status: New → Triaged
importance: Undecided → Wishlist
Changed in empathy (Ubuntu):
status: Triaged → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Accepted empathy into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in empathy (Ubuntu Lucid):
status: Triaged → Fix Committed
tags: added: verification-needed
Revision history for this message
Omer Akram (om26er) wrote : Re: Fonts are very small

I can verify that with empathy 2.30.2 I see no regression and if the adium theme is patched to not use hard coded fonts then it uses document fonts.

Martin Pitt (pitti)
tags: added: verification-done
removed: verification-needed
Omer Akram (om26er)
summary: - Fonts are very small
+ Fonts are very small with adium theme
Revision history for this message
Martin Pitt (pitti) wrote :

This was taken from git, so it should be fixed in maverick.

Changed in empathy (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package empathy - 2.30.2-0ubuntu1

---------------
empathy (2.30.2-0ubuntu1) lucid-proposed; urgency=low

  * New upstream release: (LP: #599294)
    - empathy-2.30.1.1: tests fail (Guillaume Desmottes)
    - crash when closing chat with still-open notification bubble
      (Guillaume Desmottes)
    - Can't connect chatroom if space after adress (Guillaume Desmottes)
    - Updated translations
  * debian/patches/32_append_notifications.patch:
    - refresh to new version
  * debian/patches/91_git_fix_small_font.patch:
    - take document font for adium theme to fix small fonts (LP: #531835)
 -- Didier Roche <email address hidden> Mon, 28 Jun 2010 11:36:50 +0200

Changed in empathy (Ubuntu Lucid):
status: Fix Committed → Fix Released
Revision history for this message
Alexander Sack (asac) wrote :

i am unsubscribing the MIR team ... please change title of bug to say what action is here for MIR team and drop a comment. Thanks!

Revision history for this message
Brian Curtis (bcurtiswx) wrote :

This bug isn't worthy of any more SRU's and is fixed in current release. Invalidating lucid tasks not marked as fix released.

Changed in adium-theme-ubuntu (Ubuntu Lucid):
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.