MusicPlayer applet crashes on tracks with russians symbols

Bug #523447 reported by Vitaly Danilovich
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cairo-Dock Plug-ins
Fix Released
Undecided
Unassigned
cairo-dock-plugins (Ubuntu)
Fix Released
Undecided
Unassigned
Lucid
Fix Released
Undecided
Unassigned
Maverick
Fix Released
Undecided
Unassigned

Bug Description

When just beginning to play a song where the title, artist or album, written by Russian symbols, Cairo-Dock starts turned off, and then be switched etc.

Example:
Title - Актриса-Весна
Artist - ДДТ
Album - Актриса-Весна

after some restarts I see http://img269.imageshack.us/img269/8481/94860681.png in htop

Related branches

description: updated
description: updated
Revision history for this message
Fabounet (fabounet03) wrote : Re: [Cairo-dock-team] [Bug 523447] Re: MusicPlayer applet crashes on tracks with russians symbols

Hi,
thanks for the bug report.
can you please confirm this happens with Cairo-Dock 2.1.3 ?
If it's an older version, could you please try with this one ?

2010/2/17 danvyr <email address hidden>

> ** Description changed:
>
> When just beginning to play a song where the title, artist or album,
> written by Russian symbols, Cairo-Dock starts turned off, and then be
> switched etc.
>
> Example:
> Title - Актриса-Весна
> Artist - ДДТ
> Album - Актриса-Весна
> +
> + after some restarts I see
> + http://img269.imageshack.us/img269/8481/94860681.png in htop
>
> --
> MusicPlayer applet crashes on tracks with russians symbols
> https://bugs.launchpad.net/bugs/523447
> You received this bug notification because you are a member of Cairo-
> Dock Team, which is the registrant for Cairo-Dock Plug-ins.
>
> Status in Cairo-Dock : Plug-ins: New
>
> Bug description:
> When just beginning to play a song where the title, artist or album,
> written by Russian symbols, Cairo-Dock starts turned off, and then be
> switched etc.
>
> Example:
> Title - Актриса-Весна
> Artist - ДДТ
> Album - Актриса-Весна
>
> after some restarts I see
> http://img269.imageshack.us/img269/8481/94860681.png in htop
>
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~cairo-dock-team<https://launchpad.net/%7Ecairo-dock-team>
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~cairo-dock-team<https://launchpad.net/%7Ecairo-dock-team>
> More help : https://help.launchpad.net/ListHelp
>

Revision history for this message
Vitaly Danilovich (danvyr) wrote :

My version of Cairo-Dock is 2.1.3-3, I use this repository http://ppa.launchpad.net/cairo-dock-team/ppa/ubuntu to install it.
I test today again, after two restarts Cairo-Dock starts without MusicPlayer applet and work stable.

Revision history for this message
Fabounet (fabounet03) wrote :

ok, disabling MP was the correct behavior from the dock, so this part is
good.
About the bug itself, could you please run the dock with
cairo-dock -T -l debug
(-T will stop the dock when the crash occurs)
and tell me the latest lines in the terminal when it happens ?
Thanks !
(PS : are you on a 64bits system ?)

2010/2/18 danvyr <email address hidden>

> My version of Cairo-Dock is 2.1.3-3, I use this repository
> http://ppa.launchpad.net/cairo-dock-team/ppa/ubuntu to install it.
> I test today again, after two restarts Cairo-Dock starts without
> MusicPlayer applet and work stable.
>
> --
> MusicPlayer applet crashes on tracks with russians symbols
> https://bugs.launchpad.net/bugs/523447
> You received this bug notification because you are a member of Cairo-
> Dock Team, which is the registrant for Cairo-Dock Plug-ins.
>
> Status in Cairo-Dock : Plug-ins: New
>
> Bug description:
> When just beginning to play a song where the title, artist or album,
> written by Russian symbols, Cairo-Dock starts turned off, and then be
> switched etc.
>
> Example:
> Title - Актриса-Весна
> Artist - ДДТ
> Album - Актриса-Весна
>
> after some restarts I see
> http://img269.imageshack.us/img269/8481/94860681.png in htop
>
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~cairo-dock-team<https://launchpad.net/%7Ecairo-dock-team>
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~cairo-dock-team<https://launchpad.net/%7Ecairo-dock-team>
> More help : https://help.launchpad.net/ListHelp
>

Revision history for this message
Vitaly Danilovich (danvyr) wrote :

I use 32bits system...

That was in terminal after start track http://paste.org.ru/?zcwgt1

Revision history for this message
Vitaly Danilovich (danvyr) wrote :

That was in terminal after start track

Revision history for this message
Fabounet (fabounet03) wrote :

thanks for the debug !
again it seems to crash in an unexpected place (cairo_dock_set_minutes_secondes_as_quick_info)
does it really happen only with album having non-latin characters ? it may be some buffer overflow in a string.
I've added some debug output i nMusicPlayer, could you please test with the weekly version ?
Thanks.

Revision history for this message
Fabounet (fabounet03) wrote :

also, could you please check that it happens also with another player than Rythmbox ?
and does it happen if you don't set the elapsed time as quick info ?
Thanks.

Revision history for this message
Vitaly Danilovich (danvyr) wrote :

I, check what you asked :)

It happen if set the elapsed time as quick info.

Rhythmbox and Audacious2 have have the same problem (files - bug2,3), but with Amaork2 no problem at all (file - no_bug_amarok)

And it's really happen only with album having non-latin characters... I change name of album on "123" and Cairo-Dock no crashed.

I also came across 3 albums having non-latin characters, which all worked well. (files - no_bug)

Revision history for this message
Vitaly Danilovich (danvyr) wrote :
Revision history for this message
Vitaly Danilovich (danvyr) wrote :
Revision history for this message
Vitaly Danilovich (danvyr) wrote :
Revision history for this message
Vitaly Danilovich (danvyr) wrote :
Revision history for this message
Fabounet (fabounet03) wrote :

thanks a lot for your debugs.
I'm sorry I still can't guess what's wrong exactly :-(
I have added some extra debug outputs to narrow the problem. I hope you can run it soon.

Revision history for this message
Vitaly Danilovich (danvyr) wrote :

I think something wrong with applet-amazon.c.

Revision history for this message
Fabounet (fabounet03) wrote :

I think so too ! ^_^
I've added a lot of messages in these functions, next time I hope I could
guess exactly which functions is doing wrong things.

2010/2/27 danvyr <email address hidden>

> I think something wrong with applet-amazon.c.
>
> --
> MusicPlayer applet crashes on tracks with russians symbols
> https://bugs.launchpad.net/bugs/523447
> You received this bug notification because you are a member of Cairo-
> Dock Team, which is the registrant for Cairo-Dock Plug-ins.
>
> Status in Cairo-Dock : Plug-ins: New
>
> Bug description:
> When just beginning to play a song where the title, artist or album,
> written by Russian symbols, Cairo-Dock starts turned off, and then be
> switched etc.
>
> Example:
> Title - Актриса-Весна
> Artist - ДДТ
> Album - Актриса-Весна
>
> after some restarts I see
> http://img269.imageshack.us/img269/8481/94860681.png in htop
>
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~cairo-dock-team<https://launchpad.net/%7Ecairo-dock-team>
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~cairo-dock-team<https://launchpad.net/%7Ecairo-dock-team>
> More help : https://help.launchpad.net/ListHelp
>

Revision history for this message
Vitaly Danilovich (danvyr) wrote :

When I disallow Cairo-Dock to download missing covers in settings of MusicPlayer applet - Cairo-Dock no crashed.

Revision history for this message
Vitaly Danilovich (danvyr) wrote :

Sorry, I was so happy and do mistake with previous messege :(. Ignore it.

Revision history for this message
Fabounet (fabounet03) wrote :

still present in the 2.1.3-8 (or 2.1.4) ?

Revision history for this message
Vitaly Danilovich (danvyr) wrote :

still present in the 2.1.3-8

Revision history for this message
Matthieu Baerts (matttbe) wrote :

It's hard to find the cause :-/ . Is it still present in the v.2.1.3-9 ?

Revision history for this message
Tofe (chris-chapuis) wrote :

It may be caused by a bad support of some unicode string. Looking at the
error makes me think there's a sort of buffer overflow there:

applet-amazon.c:_url_encode:220

When I look at this location, I see this:

    }while(*++s); // avance d'un cran dans la chaine. Si on est pas à la
fin, on continue...
    s = str;
    /// la ligne suivane peut planter ...
    cd_debug ("allocation of %d bytes...\n", lenght + 1);
    t = g_new (gchar, lenght + 1); // Allocation à la bonne taille

For example, is "while(*++s)" valid for a unicode string?

Tofe

On Fri, Apr 23, 2010 at 3:22 PM, Matthieu Baerts <email address hidden> wrote:

> It's hard to find the cause :-/ . Is it still present in the v.2.1.3-9 ?
>
> --
> MusicPlayer applet crashes on tracks with russians symbols
> https://bugs.launchpad.net/bugs/523447
> You received this bug notification because you are a member of Cairo-
> Dock Team, which is the registrant for Cairo-Dock Plug-ins.
>
> Status in Cairo-Dock : Plug-ins: New
>
> Bug description:
> When just beginning to play a song where the title, artist or album,
> written by Russian symbols, Cairo-Dock starts turned off, and then be
> switched etc.
>
> Example:
> Title - Актриса-Весна
> Artist - ДДТ
> Album - Актриса-Весна
>
> after some restarts I see
> http://img269.imageshack.us/img269/8481/94860681.png in htop
>
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~cairo-dock-team<https://launchpad.net/%7Ecairo-dock-team>
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~cairo-dock-team<https://launchpad.net/%7Ecairo-dock-team>
> More help : https://help.launchpad.net/ListHelp
>

Revision history for this message
Fabounet (fabounet03) wrote :
Download full text (3.1 KiB)

we are supposed to receive and return UTF-8 everywhere in the dock.
it's valid to do while(*++s) since a nul byte is not permitted in any UTF-8
character (except the NULL one).
I also think it's a memory corruption around this function in one of the
strings, but I can't find where exactly :-/

2010/4/23 Tofe <email address hidden>

> It may be caused by a bad support of some unicode string. Looking at the
> error makes me think there's a sort of buffer overflow there:
>
> applet-amazon.c:_url_encode:220
>
> When I look at this location, I see this:
>
> }while(*++s); // avance d'un cran dans la chaine. Si on est pas à la
> fin, on continue...
> s = str;
> /// la ligne suivane peut planter ...
> cd_debug ("allocation of %d bytes...\n", lenght + 1);
> t = g_new (gchar, lenght + 1); // Allocation à la bonne taille
>
> For example, is "while(*++s)" valid for a unicode string?
>
> Tofe
>
> On Fri, Apr 23, 2010 at 3:22 PM, Matthieu Baerts <email address hidden>
> wrote:
>
> > It's hard to find the cause :-/ . Is it still present in the v.2.1.3-9 ?
> >
> > --
> > MusicPlayer applet crashes on tracks with russians symbols
> > https://bugs.launchpad.net/bugs/523447
> > You received this bug notification because you are a member of Cairo-
> > Dock Team, which is the registrant for Cairo-Dock Plug-ins.
> >
> > Status in Cairo-Dock : Plug-ins: New
> >
> > Bug description:
> > When just beginning to play a song where the title, artist or album,
> > written by Russian symbols, Cairo-Dock starts turned off, and then be
> > switched etc.
> >
> > Example:
> > Title - Актриса-Весна
> > Artist - ДДТ
> > Album - Актриса-Весна
> >
> > after some restarts I see
> > http://img269.imageshack.us/img269/8481/94860681.png in htop
> >
> >
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~cairo-dock-team<https://launchpad.net/%7Ecairo-dock-team>
> <https://launchpad.net/%7Ecairo-dock-team>
> > Post to : <email address hidden>
> > Unsubscribe : https://launchpad.net/~cairo-dock-team<https://launchpad.net/%7Ecairo-dock-team>
> <https://launchpad.net/%7Ecairo-dock-team>
> > More help : https://help.launchpad.net/ListHelp
> >
>
> --
> MusicPlayer applet crashes on tracks with russians symbols
> https://bugs.launchpad.net/bugs/523447
> You received this bug notification because you are a member of Cairo-
> Dock Team, which is the registrant for Cairo-Dock Plug-ins.
>
> Status in Cairo-Dock : Plug-ins: New
>
> Bug description:
> When just beginning to play a song where the title, artist or album,
> written by Russian symbols, Cairo-Dock starts turned off, and then be
> switched etc.
>
> Example:
> Title - Актриса-Весна
> Artist - ДДТ
> Album - Актриса-Весна
>
> after some restarts I see
> http://img269.imageshack.us/img269/8481/94860681.png in htop
>
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~cairo-dock-team<https://launchpad.net/%7Ecairo-dock-team>
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~cairo-dock-team<https://launchpad.net/%7Ecairo-dock-team>
> More help : https://help.launchpad.net/ListH...

Read more...

Revision history for this message
Fabounet (fabounet03) wrote :

ok I could fix it, thanks a lot for your debugs, and sorry for taking so much time to fix it !

Changed in cairo-dock-plug-ins:
status: New → Fix Committed
Revision history for this message
Martin Pitt (pitti) wrote :

Fixed in maverick already.

Changed in cairo-dock-plugins (Ubuntu Maverick):
status: New → Fix Released
tags: added: verification-needed
Revision history for this message
Martin Pitt (pitti) wrote : Please test proposed package

Accepted cairo-dock-plug-ins into lucid-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Revision history for this message
Martin Pitt (pitti) wrote :

Anyone who can test this?

Revision history for this message
Matthieu Baerts (matttbe) wrote :

As said on bug #576647, this bug is now fixed!
Thank you

Changed in cairo-dock-plugins (Ubuntu Lucid):
status: New → Fix Released
Martin Pitt (pitti)
Changed in cairo-dock-plugins (Ubuntu Lucid):
status: Fix Released → Fix Committed
tags: added: verification-done
removed: verification-needed
Changed in cairo-dock-plug-ins:
status: Fix Committed → Fix Released
Revision history for this message
Rolf Leggewie (r0lf) wrote :

lucid has seen the end of its life and is no longer receiving any updates. Marking the lucid task for this ticket as "Won't Fix".

Changed in cairo-dock-plugins (Ubuntu Lucid):
status: Fix Committed → Won't Fix
Revision history for this message
Matthieu Baerts (matttbe) wrote :

(Seems we forgot to change the status as "Fix Released")

Changed in cairo-dock-plugins (Ubuntu Lucid):
status: Won't Fix → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.