IBAN accounts upper case

Bug #523428 reported by Ferdinand
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
OpenERP R&D Addons Team 3

Bug Description

http://en.wikipedia.org/wiki/International_Bank_Account_Number

Replace the letters in the string with digits, expanding the string as necessary, such that A=10, B=11 and Z=35. Each alphabetic character is therefore replaced by 2 digits.

implies that alpha chars must be upper case
hence an automatic conversin to uppercase should take place to avoid saveing invalid IBAN (and account) numbers

Changed in openobject-addons:
importance: Undecided → Wishlist
assignee: nobody → JMA(Open ERP) (jma-openerp)
Revision history for this message
Ferdinand (office-chricar) wrote :

Sometimes I do not understand

IBAN is a public specification requiring capital letters and OpenERP does exactly the contrary and it's classified as a wish. ???

Revision history for this message
Ferdinand (office-chricar) wrote :

http://www.daniweb.com/forums/thread238464.html

IMHO we also should store IBAN formatted as done in the last lines of the attached code and ONLY remove blanks for EDI.

It is impossible to proof read a 22 digit string without formatting.

Revision history for this message
JMA(Open ERP) (jma-openerp) wrote :

Hello Ferdinand,

I have gone through your post and also the article about the International Bank Account Number on wikipedia link you sent.
In order to maintain the integrity of the IBAN they have talked about the algorithm to calculate and validate the checksum.

Example:
                IBAN: GB82 WEST 1234 5698 7654 32
                Rearrange: W E S T12345698765432 G B82
                Modulus: 3214282912345698765432161182 mod 97 = 1

I have replaced each letter in the string with two digits, thereby expanding the string, where A=10, B=11, ..., Z=35.
The attachment contains the changes for the validation of the IBAN in accordance with the algorithm.

Please apply the changes and advice us.

Thank you.

Revision history for this message
Ferdinand (office-chricar) wrote :

I am almost sure that this patch will NOT return capital letters as required by the specs.

Revision history for this message
JMA(Open ERP) (jma-openerp) wrote :

Hello Ferdinand,

I need to clarify as you have talked about:

Replace the letters in the string with digits, expanding the string as necessary, such that A=10, B=11 and Z=35. Each alphabetic character is therefore replaced by 2 digits.

This is what has been stated over here also: http://en.wikipedia.org/wiki/International_Bank_Account_Number

So when we enter the IBAN number:
Behaviour 1:
                    IBAN(entered): GB82 WEST 1234 5698 7654 32
                    IBAN(saved): 3214282912345698765432161182 mod 97 = 1
Behaviour 2:
                    IBAN(entered): gb82 west 1234 5698 7654 32
                    IBAN(saved): GB82 WEST 1234 5698 7654 32

Do you want the IBAN to be replaced by the numbers respectively starting from A=10, B=11, ..., Z=35?
Or you want the lower case letters to be converted into uppercase?

Can you please specify with an example, what should be the actual behaviour?

Thank you for guiding us.

Revision history for this message
Ferdinand (office-chricar) wrote :

if it is necessary/simple to calculate the checksum I am fine to convert
letters to lower case, but the user must see upper case and it must also be
stored in upper case.

Behaviour 2 is correct,
but the user will not enter the blanks - expanding should be done by the
system

what to do is remove existing blanks and regroup using the code in the link

but we have to notify the "payment" code because it needs to remove the blanks
before sending the account to the bank

Changed in openobject-addons:
assignee: JMA(Open ERP) (jma-openerp) → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
status: New → Confirmed
Revision history for this message
Ferdinand (office-chricar) wrote :

well i just want to emphasize that it must be possible to enter the iban code with or without blanks ....
then calculate the checksum
then store store IBAN in uppercase and grouped

the paymodule must remove the blanks for EDI

Revision history for this message
Fabien (Open ERP) (fp-tinyerp) wrote :

the only thing to change is to put all letters in uppercase.

Revision history for this message
Jay Vora (Serpent Consulting Services) (jayvora) wrote :

One should consider things mentioned on bug 635682.
Thanks.

qdp (OpenERP) (qdp)
Changed in openobject-addons:
importance: Wishlist → Low
importance: Low → Wishlist
milestone: none → 6.0-rc2
Revision history for this message
Olivier Dony (Odoo) (odo-openerp) wrote :

Resetting importance to Low to keep it in the radar for rc2

Changed in openobject-addons:
importance: Wishlist → Low
Changed in openobject-addons:
status: Confirmed → In Progress
Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
Rifakat Husen (OpenERP) (rha-openerp) wrote :

Hello Ferdinand,

We have applied your patch in Addons3 branch. Revision ID: mra@mra-laptop-20101123044448-uxcvkfqibbec96xl
and revno: 4688

Thank you for contribution,
rha

Changed in openobject-addons:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.