[Test] Lossless rotate doesn't work
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Phatch |
Fix Released
|
High
|
Stani |
Bug Description
Hi Juho, can you provide a patch for this?
Error 0:Can not apply action Lossless JPEG on image 'IMG_8763.JPG' in folder:
/home/stani/
super(type, obj): obj must be an instance or subtype of type
Action:{'fields': {'All': '30%',
'Angle ': '90 degrees',
'Copy': 'Comments',
'File Name': u'<filename>
'In': u'<folder>
'Left': '0px',
'Mode': 'All',
'Show Advanced Options': 'no',
'Top': '0px',
'Update Exif Thumbnail': 'yes',
'Update JPEG': 'yes',
'Update Orientation Tag': 'yes',
'label': 'Lossless JPEG'}
Traceback (most recent call last):
File "/usr/lib/
photo = action.apply(photo, read_only_settings, cache)
File "/usr/lib/
self.
File "/usr/lib/
super(
TypeError: super(type, obj): obj must be an instance or subtype of type
*
Changed in phatch: | |
milestone: | 0.2.6 → 0.2.7 |
summary: |
- Lossless rotate doesn't work + [Test] Lossless rotate doesn't work |
Changed in phatch: | |
assignee: | Juho Vepsäläinen (bebraw) → Andrea Ambu (andreambu) |
status: | Confirmed → In Progress |
Changed in phatch: | |
status: | Fix Committed → Fix Released |
I don't have exiftran installed nor Ubuntu set up atm. I did glance at the code, however. You could try to replace the offending line photo)" with
"super(JpegUtility, self).execute(
and remove that part from the end of the call method. It looks a bit suspicious to me (I expect it should call exiftran/jpegtran only if provided file happens to be a jpeg, no?).
It's also curious that execute method of JpegUtility contains almost exact content as the call method of LossLessSaveUti lityMixin. If you end up doing the above change and it works out ok, you might want to eliminate JpegUtility class altogether. Utility looks like a good candidate for removal as well.