Make combine-css skip work when it is not needed
Bug #514400 reported by
Gary Poster
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Paul Hummer | ||
Bug Description
combine-css is run every time we do a make. It regenerates the file every time. I suggested that maybe we could use Makefile dependencies, but Salgado said that we need to compare the mtime of all the files in bin/combine-css with the mtime of combo.css to decide whether or not we should re-generate. That sounds fine to me.
Related branches
lp:~rockstar/launchpad/makefile-hackery
- Edwin Grubbs (community): Approve
-
Diff: 58 lines (+21/-7)2 files modifiedMakefile (+5/-0)
buildout-templates/bin/combine-css.in (+16/-7)
| Changed in launchpad-foundations: | |
| assignee: | Guilherme Salgado (salgado) → Paul Hummer (rockstar) |
| Changed in launchpad-foundations: | |
| status: | Triaged → In Progress |
Revision history for this message
| Diogo Matsubara (matsubara) wrote Bug fixed by a commit | #1 |
| Changed in launchpad-foundations: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Paul Hummer (rockstar) wrote | #2 |
| Changed in launchpad-foundations: | |
| status: | Fix Committed → Fix Released |
| milestone: | none → 10.02 |
To post a comment you must log in.
Fixed in devel r10341 <http://