Launchpad itself

"sources.changes" is not a well-known term

Bug #509791 reported by William Grant
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Julian Edwards
Launchpad itself 10.01

Bug Description

The Launchpad term "changesfile" was recently replaced by "sources.changes", which is not a term I have ever heard before.

Perhaps "source.changes" was meant, but I don't think that it's a good term to use either.

Tags: lp-soyuz

Related branches

lp:~jamalta/launchpad/changesfile-509791
Julian Edwards (community): Approve
Diff: 177 lines (+18/-18)
7 files modified
lib/lp/soyuz/stories/ppa/xx-copy-packages.txt (+4/-4)
lib/lp/soyuz/stories/ppa/xx-delete-packages.txt (+4/-4)
lib/lp/soyuz/stories/ppa/xx-ppa-files.txt (+1/-1)
lib/lp/soyuz/stories/ppa/xx-ppa-packages.txt (+3/-3)
lib/lp/soyuz/stories/soyuz/xx-distroseries-sources.txt (+3/-3)
lib/lp/soyuz/templates/distroseriessourcepackagerelease-index.pt (+2/-2)
lib/lp/soyuz/templates/sourcepackagepublishinghistory-listing-archive-detailed.pt (+1/-1)
Revision history for this message
William Grant (wgrant) wrote :

Also, it appears to be used for binary changes files too.

Revision history for this message
Stuart Bishop (stub) wrote :

This change was Bug #253525, which landed in lp:~launchpad/devel r10193 in case reverting is desirable.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

I'll fix it "properly" myself. I'll use "changes file" which makes the most sense to me and most people, and works for binaries.

Changed in soyuz:
status: New → Triaged
importance: Undecided → Medium
assignee: nobody → Julian Edwards (julian-edwards)
milestone: none → 10.01
Revision history for this message
Jamal Fanaian (jamalta) wrote :

Well, I apologize that you feel so against this change. I had discussed it with a team member before I implemented the change, and then had a different team member approve the changes in my MP.

Julian, if you haven't already made the changes, I can quickly do it as I already have all the places in the templates and tests that this is referenced, as I made the change from changesfile to sources.changes just a few days ago. Let me know, I could have it fixed by lunch time EST.

Revision history for this message
Julian Edwards (julian-edwards) wrote : Re: [Bug 509791] Re: "sources.changes" is not a well-known term

Right, sorry, the person who said it was ok wasn't a Soyuz expert. However,
having just reviewed your branch, thanks very much for fixing it already!

Julian Edwards (julian-edwards)
Changed in soyuz:
status: Triaged → Fix Committed
Julian Edwards (julian-edwards)
Changed in soyuz:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.