in buildout.cfg "eggs=" specification lines with comments only break easy install

Bug #507866 reported by Justas Sadzevičius
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
SchoolTool
Fix Released
Low
Justas Sadzevičius
SchoolTool Gradebook
Fix Released
Undecided
Unassigned
SchoolTool Intervention
Fix Released
Undecided
Unassigned
SchoolTool Journal
Fix Released
Undecided
Unassigned

Bug Description

We need to change in all base.cfg files:
eggs = # set to package name in buildout.cfg
to:
# set to package name in buildout.cfg
eggs =

Reason:
When people extend eggs (instead of replacing) in buildout.cfg, like this:
eggs += schooltool

easy_install does not filter out "# set to package name in buildout.cfg" and passes it as a *separate* package requirement to pkg_resources. pkg_resources then apply regex to obtain the required package name and fails. Kudos to easy_install.

P.S.:
"eggs=schooltool # comment
           schooltool.gradebook" works, but
"eggs=schooltool
           # comment
           schooltool.gradebook" *does not*

Changed in schooltool:
assignee: nobody → Justas Sadzevičius (justas-pov)
importance: Undecided → High
status: New → In Progress
affects: schooltool → schooltool.gradebook
affects: schooltool.gradebook → schooltool
Changed in schooltool:
status: In Progress → Fix Committed
Changed in schooltool.gradebook:
status: New → Fix Committed
Changed in schooltool.intervention:
status: New → Fix Committed
Changed in schooltool.lyceum.journal:
status: New → Fix Committed
Changed in schooltool:
importance: High → Low
milestone: none → 1.3.1
Changed in schooltool.intervention:
milestone: none → 0.2.1
Changed in schooltool:
status: Fix Committed → Fix Released
Changed in schooltool.gradebook:
status: Fix Committed → Fix Released
Changed in schooltool.lyceum.journal:
status: Fix Committed → Fix Released
Changed in schooltool.intervention:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.