Resubmit should allow changing the branches
Bug #504369 reported by
Aaron Bentley
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Aaron Bentley | ||
Bug Description
Sometimes the information in a merge proposal is wrong, e.g.
- it has been targetted at the wrong branch
- the prerequesite branch is wrong or missing
Sometimes a new person will take ownership of a piece of work, meaning they will have to create a new Launchpad branch.
We shouldn't allow changing these attributes on a merge proposal directly, because this can be abused to change the meaning of the votes/status retroactively (making someone approve something they would not have approved, etc.).
Instead, we should allow the branches to be changed when resubmitting a proposal (but defaulted to the values from the branch being superseded).
Related branches
lp:~abentley/launchpad/resubmit-change-branch
- Paul Hummer (community): Approve (ui)
- Brad Crittenden (community): Approve (code)
-
Diff: 407 lines (+218/-31)6 files modifiedlib/lp/code/browser/branchmergeproposal.py (+37/-5)
lib/lp/code/browser/tests/test_branchmergeproposal.py (+94/-1)
lib/lp/code/interfaces/branchmergeproposal.py (+25/-11)
lib/lp/code/model/branchmergeproposal.py (+20/-8)
lib/lp/code/model/tests/test_branchmergeproposal.py (+38/-0)
lib/lp/code/templates/branchmergeproposal-resubmit.pt (+4/-6)
| Changed in launchpad-code: | |
| status: | New → Triaged |
| importance: | Undecided → Medium |
Revision history for this message
| Robert Collins (lifeless) wrote | #1 |
| Changed in launchpad-code: | |
| milestone: | none → 10.11 |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote Bug fixed by a commit | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad-code: | |
| assignee: | nobody → Aaron Bentley (abentley) |
| status: | Triaged → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad-code: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Someone can just push different code up to invalidate an existing vote - I think this approach adds unnecessary friction to the UI. Certainly in the bzr team we're finding resubmit unpleasant to use, and it doesn't fit the mental model of a changing bit of code that is being evolved-
I can see a case for locking down an MP when its in state 'approved', but thats really the last step in the process anyway.