process-mail.py "need more than 1 value to unpack"
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
High
|
Diogo Matsubara | ||
Bug Description
Every hour, process-mail.py is generating several error messages of the form:
2010-01-07 02:33:15 ERROR An exception was raised inside the handler:
[...] (need more than 1 value to unpack)
The traceback is:
Traceback (most recent call last):
File "/srv/launchpad
user, domain = email_addr.
ValueError: need more than 1 value to unpack
The trigger is a malformed To: header - an attempt by spammers to get things past filters:
To: <<email address hidden>,
<email address hidden>,
<email address hidden>,
<email address hidden>,
<email address hidden>>
We need to handle this better to allow us to again monitor this script for genuine failures.
Recently: OOPS-1607CEMAIL801
Related branches
- Curtis Hovey (community): Approve (rc)
- Graham Binns (community): Approve (code)
-
Diff: 115 lines (+54/-0)4 files modifiedlib/canonical/launchpad/mail/ftests/emails/invalid-to-header.txt (+23/-0)
lib/canonical/launchpad/mail/incoming.py (+9/-0)
lib/canonical/launchpad/mail/tests/test_incoming.py (+21/-0)
lib/lp/services/mail/sendmail.py (+1/-0)
| Curtis Hovey (sinzui) wrote | #1 |
| affects: | launchpad → launchpad-foundations |
| Changed in launchpad-foundations: | |
| importance: | Undecided → High |
| status: | New → Triaged |
| tags: | added: oops |
| description: | updated |
| Changed in launchpad-foundations: | |
| assignee: | nobody → Diogo Matsubara (matsubara) |
| milestone: | none → 10.05 |
| tags: | added: canonical-losa-lp |
| Changed in launchpad-foundations: | |
| status: | Triaged → Fix Committed |
| Changed in launchpad-foundations: | |
| status: | Fix Committed → Fix Released |
| Ursula Junque (ursinha) wrote Bug fixed by a commit | #2 |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
Will a simple try/except suffice with a comment that we break because the email/domain is not valid?