regression with delivery including service

Hi i installed, manofacturing and delivery modules, i reproduce the process as you says and when create the invoice from picking created and i get in the invoice lines:
The product and the ATX and the post express as delivery.
I dont see 2 lines from delivery.
Could you reproduce the bug? or maybe something else?

Regards,

Hello,

I made a quick test again,

I was unable to reproduce what I called "REGRESSION 1" (2 lines of service instead of 1). So we will test that one again.

However, I absolutely confirm that "REGRESSION 2" (sale order workflow stuck in "in progress" state is there and this is an important regression vs version 5.0.6 and previous.

Hello All,

I can confirm regression 2 as well.

case #1 is normal:
  - you have to choose between adding a line for delivery in the SO based on theorical weight or
  - asking OpenERP to add a delivery line at each delivery based on real weight
You did both, it's normal that you have 2 lines.

case #1 part 2:
  - I fixed the test_finished method., r2463

case #2:
  - related to case #1 part 2

Hello,

can anyone confirm it's fixed.

I updated my addons code to r2463 and when I make a new order with:
1 line with 1 ATX product
1 line with a delivery cost

then if I validate the picking and pay the invoice,

the status of the order is still stuck in "in progress" status
and while the picked progess bar show 100%, the picked checkbox in the order form is not checked.

Confirmation?

can you double check please, I see nowhere what could be your fix, are you sure you pushed it? I can only see a merge and older fixes in your commit 2463.

Hello,

The bug is not fixed, I have checked now.

Look fixed if you run the scheduler. I'm not sure this is the expected behavior though (see last yesterday IRC logs). Will provide more info on this after some sleep, but if somebody can test further meanwhile, that would help.

All right, tested again. If the scheduler runs, the order status is properly completed to 'done', so I consider it fixed until the contrary is proven.

rvalyi,

can you confirm that the bug doesnt exist when the order has both the product and service ???

Sharoon, you have to let the scheduler run for the order state to complete,
but provided that it works. So again, set it as closed unlike somebody
claims that is not the expected behavior.

On Tue, Dec 8, 2009 at 7:38 PM, Sharoon Thomas
<email address hidden>wrote:

> rvalyi,
>
> can you confirm that the bug doesnt exist when the order has both the
> product and service ???
>
> --
> regression with delivery including service
> https://bugs.launchpad.net/bugs/491375
> You received this bug notification because you are a direct subscriber
> of the bug.
>
> Status in OpenObject Addons Modules: Fix Released
>
> Bug description:
> Hello, using last 5.0 branch revisions:
> server #1892
> addons: #2472
>
> with fresh manufacturing + demo data profile.
>
> There are actually two regressions linked together. Regression 1 only
> occurs with the delivery module I think while regression 2 occurs with any
> order containing both physical products and service.
>
>
> Make a new sale order with one order line: ex 1 ATX product.
> Add delivery cost line using the "add delivery cost" wizard button on the
> right.
> Set the order as "Invoice from picking" on the "other data" tab
>
> Now validate the order.
> Validate the newly created expedition picking.
> Now, from that picking, create an invoice.
>
>
> Now open the newly created invoice.
>
> REGRESSION 1:
> The invoice now contains 2 delivery costs lines instead of just 1!!!
>
> Actually, now it seems that as soon as the order has a "delivery method"
> set, then a delivery cost line will be added to the invoice while the order
> doesn't have it (so there is now a mismacth between the order and the
> invoice in term of description and price). So if you add a delivery cost
> line to the order, then it will also set the delivery method and lead to 2
> delievery cost lines on the invoice, as described which is plain wrong and
> an incredible regression since version 5.0.6.
>
>
> REGRESSION 2:
>
> Pay/reconcile the newly created invoice containing the 2 delivery cost
> lines.
> You'll see that for the sale order workflow is stuck into the "progress"
> state, never reaching completion as it did in previous versions like 5.0.6.
>
> You'll see that actually, there is "confirmed" (instead of done)
> procurement associated to the order delivery cost line which block the whole
> workflow I think.
>
> This regression 2 isn't specific to the delivery module. If you sale any
> physical product along with a service order line, then your order workflow
> will never complete anymore.
>
> Again, this is an other incredible regression since v5.0.6.
>
>
> Hope this helps
>
> To unsubscribe from this bug, go to:
> https://bugs.launchpad.net/openobject-addons/+bug/491375/+subscribe
>

"So again, set it as closed unlike somebody
claims that is not the expected behavior."

-> Which happen here by arguably "functional specialists":
https://bugs.launchpad.net/bugs/519034

(no flagging them as duplicate however because this report talks about several points and only one of them is questioned in https://bugs.launchpad.net/bugs/519034 )