launchpadlib

login_with(): Please support optional credentials_file argument

Bug #485797 reported by Martin Pitt
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
launchpadlib
Fix Released
Undecided
Unassigned
python-launchpadlib (Ubuntu)
Fix Released
Wishlist
Martin Pitt

Bug Description

Thanks for login_with(), it potentially removes so much redundant code.

However, to support existing configurations I would like to be able to specify cache dir and credentials path separately. A lot of people already have a ~/.cache/apport/launchpad.credentials, which I would like to continue to use. I don't want to use a permanent cache dir in apport-collect either, so I'd set launchpad_dir to a mkdtemp in apport.

For this, login_with needs a new optional argument "credentials_file".

Related branches

lp:~pitti/launchpadlib/login_with-credentials_file
Gavin Panella: Approve
Diff: 95 lines (+39/-13)
2 files modified
src/launchpadlib/launchpad.py (+17/-13)
src/launchpadlib/tests/test_launchpad.py (+22/-0)
lp:~ubuntu-core-dev/launchpadlib/ubuntu
lp:ubuntu/lucid/python-launchpadlib
Revision history for this message
Martin Pitt (pitti) wrote :

I will apply this to the Ubuntu package once it's accepted upstream, to greatly simplify the apport code.

Changed in launchpadlib:
assignee: nobody → Martin Pitt (pitti)
status: New → Fix Committed
Changed in python-launchpadlib (Ubuntu):
assignee: nobody → Martin Pitt (pitti)
importance: Undecided → Wishlist
status: New → In Progress
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package python-launchpadlib - 1.5.3+bzr75-0ubuntu1

---------------
python-launchpadlib (1.5.3+bzr75-0ubuntu1) lucid; urgency=low

  * New upstream release:
    - Added a number of new sample scripts from elsewhere.
    - Added a reference to the production Launchpad instance.
    - Made it easier to specify a Launchpad instance to run against.
    - Moved some more code from launchpadlib into the more generic
      lazr.restfulclient.
  * Upgraded to upstream bzr head:
    - In Launchpad.login_with(), create the launchpadlib_dir with secure
      (0700) permissions, or chmod existing directory to be secure. Previously
      no attempt was made to ensure security. Landed on behalf of Kees Cook.
    - Add a credentials_file parameter to login_with() so that the specific
      file in which to save and look for credentials can be given, rather than
      using the default. (LP: #485797)
  * debian/control: Change branch owner to ubuntu-core-dev since package is in
    main. Update Vcs-Bzr accordingly.
  * Add debian/watch.
  * debian/control: Renamed python-lazr-restfulclient dependency to new name
    python-lazr.restfulclient, and bump to >= 0.9.10, according to setup.py.
  * debian/control: Renamed python-lazr-uri dependency to new name
    python-lazr.uri.
 -- Martin Pitt <email address hidden> Mon, 07 Dec 2009 10:23:56 +0100

Changed in python-launchpadlib (Ubuntu):
status: In Progress → Fix Released
Martin Pitt (pitti)
Changed in launchpadlib:
assignee: Martin Pitt (pitti) → nobody
Gary Poster (gary)
Changed in launchpadlib:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.