Expose TranslationImportQueueEntry.setStatus through the API
Bug #482267 reported by
Henning Eggers
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Medium
|
Henning Eggers | ||
Bug Description
In order to use the ajax picker to change the status in the queue, setStatus needs to be available through the API. The tricky thing here is that allowed status values are dependent on the user and this needs to be enforced in the model method. So setStatus needs and extra parameter "user" that needs to be added for all call sites ...
Related branches
lp:~henninge/launchpad/bug-422466-api
- Henning Eggers (community): Disapprove (code)
- Edwin Grubbs (community): Needs Fixing (code)
-
Diff: 1442 lines (+412/-122)26 files modifiedlib/canonical/launchpad/security.py (+10/-14)
lib/lp/translations/browser/hastranslationimports.py (+4/-4)
lib/lp/translations/browser/translationimportqueue.py (+1/-1)
lib/lp/translations/doc/poexport-language-pack.txt (+6/-2)
lib/lp/translations/doc/poimport-pofile-not-exported-from-rosetta.txt (+5/-3)
lib/lp/translations/doc/poimport-pofile-old-po-imported.txt (+6/-4)
lib/lp/translations/doc/poimport-pofile-syntax-error.txt (+10/-8)
lib/lp/translations/doc/poimport-potemplate-syntax-error.txt (+5/-3)
lib/lp/translations/doc/poimport.txt (+14/-14)
lib/lp/translations/doc/rosetta-karma.txt (+6/-6)
lib/lp/translations/doc/rosetta-poimport-script.txt (+4/-2)
lib/lp/translations/doc/translationimportqueue.txt (+43/-32)
lib/lp/translations/interfaces/translationimportqueue.py (+37/-8)
lib/lp/translations/model/pofile.py (+5/-2)
lib/lp/translations/model/potemplate.py (+5/-2)
lib/lp/translations/model/translationbranchapprover.py (+3/-1)
lib/lp/translations/model/translationimportqueue.py (+64/-8)
lib/lp/translations/scripts/po_import.py (+2/-1)
lib/lp/translations/stories/webservice/xx-translationimportqueue.txt (+17/-2)
lib/lp/translations/tests/test_autoapproval.py (+7/-1)
lib/lp/translations/tests/test_translationbranchapprover.py (+3/-1)
lib/lp/translations/tests/test_translationimportqueue.py (+125/-0)
lib/lp/translations/utilities/permission_helpers.py (+21/-0)
lib/lp/translations/utilities/tests/helpers.py (+3/-1)
lib/lp/translations/utilities/tests/test_xpi_import.py (+3/-1)
lib/lp/translations/utilities/tests/test_xpi_po_exporter.py (+3/-1)
lp:~henninge/launchpad/bug-482267
- Edwin Grubbs (community): Approve (code)
-
Diff: 1439 lines (+411/-122)26 files modifiedlib/canonical/launchpad/security.py (+10/-14)
lib/lp/translations/browser/hastranslationimports.py (+4/-4)
lib/lp/translations/browser/translationimportqueue.py (+1/-1)
lib/lp/translations/doc/poexport-language-pack.txt (+6/-2)
lib/lp/translations/doc/poimport-pofile-not-exported-from-rosetta.txt (+5/-3)
lib/lp/translations/doc/poimport-pofile-old-po-imported.txt (+6/-4)
lib/lp/translations/doc/poimport-pofile-syntax-error.txt (+10/-8)
lib/lp/translations/doc/poimport-potemplate-syntax-error.txt (+5/-3)
lib/lp/translations/doc/poimport.txt (+14/-14)
lib/lp/translations/doc/rosetta-karma.txt (+6/-6)
lib/lp/translations/doc/rosetta-poimport-script.txt (+4/-2)
lib/lp/translations/doc/translationimportqueue.txt (+43/-32)
lib/lp/translations/interfaces/translationimportqueue.py (+37/-8)
lib/lp/translations/model/pofile.py (+5/-2)
lib/lp/translations/model/potemplate.py (+5/-2)
lib/lp/translations/model/translationbranchapprover.py (+3/-1)
lib/lp/translations/model/translationimportqueue.py (+63/-8)
lib/lp/translations/scripts/po_import.py (+2/-1)
lib/lp/translations/stories/webservice/xx-translationimportqueue.txt (+17/-2)
lib/lp/translations/tests/test_autoapproval.py (+7/-1)
lib/lp/translations/tests/test_translationbranchapprover.py (+3/-1)
lib/lp/translations/tests/test_translationimportqueue.py (+125/-0)
lib/lp/translations/utilities/permission_helpers.py (+21/-0)
lib/lp/translations/utilities/tests/helpers.py (+3/-1)
lib/lp/translations/utilities/tests/test_xpi_import.py (+3/-1)
lib/lp/translations/utilities/tests/test_xpi_po_exporter.py (+3/-1)
Revision history for this message
| Henning Eggers (henninge) wrote | #1 |
| Changed in rosetta: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Ursula Junque (ursinha) wrote A commit mentioned this bug | #2 |
| tags: | added: qa-needstesting |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in rosetta: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in devel 9906 and db-devel 8695.