Bazaar

Unwanted side effect of umask and 'bzr rspush'

Bug #4800 reported by Matt Zimmerman
6
Affects Status Importance Assigned to Milestone
Bazaar
Invalid
High
Unassigned
BzrTools
Won't Fix
Undecided
Unassigned
bzrtools (Ubuntu)
Won't Fix
Low
Unassigned

Bug Description

Since 'bzr push' seems to preserve permissions, I regularly run into the following situation:

- Perform some operations on the tree
- 'bzr push' to my public mirror served via http
- Receive complaints from downstreams of 403 errors
- Fix permissions locally and re-push

I use a 007 umask on this system.

Revision history for this message
Matt Zimmerman (mdz) wrote :

<mbp> are you using rsync-based push or sftp?
<mdz> Pushing to rookery.ubuntu.com:public_html/bazaar/ltsp/main/
<mdz> seems to call rsync
[...]
<lifeless> mbp: mdz is using the bzrtools push wrapper

Revision history for this message
Martin Pool (mbp) wrote :

I think that the push plugin should be changed to invoke rsync -r not rsync -a, so that it doesn't override the default remote permissions.

You can try this as a local change in bzrtools/push.

Revision history for this message
Martin Pool (mbp) wrote : change args to rsync

This patch to bzrtools probably fixes it

Revision history for this message
Matt Zimmerman (mdz) wrote : Re: [Bug 4800] Unwanted side effect of umask and 'bzr push'

On Wed, Nov 23, 2005 at 10:41:27PM -0000, Martin Pool wrote:
> Public bug report changed:
> https://launchpad.net/malone/bugs/4800
>
> - Changed attachments:
> Added: change args to rsync
> http://librarian.launchpad.net/1185326/rsync-push.diff

We don't need to preserve symlinks?

--
 - mdz

Revision history for this message
Martin Pool (mbp) wrote :

On 23 Nov 2005, Matt Zimmerman <email address hidden> wrote:
> We don't need to preserve symlinks?

You're quite right, there should be a -l in there as well.

--
Martin

Revision history for this message
Aaron Bentley (abentley) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
| Public bug report changed:
| https://launchpad.net/malone/bugs/4800
|
| Comment:
| I think that the push plugin should be changed to invoke rsync -r not
| rsync -a, so that it doesn't override the default remote permissions.

What about the execute bit?

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFDhQol0F+nu1YWqI0RAp7tAJwPHFc+Zt3puwCgVKOpFMQyLgVwLwCePs/T
w/zpQrup8/d6Lg+OnqBVPpc=
=teek
-----END PGP SIGNATURE-----

Revision history for this message
Robert Collins (lifeless) wrote : Re: Unwanted side effect of umask and 'bzr push'

Aaron - where is this at? If the rsync command lines have been changed, we can close this.

Changed in bzr:
status: Unconfirmed → Confirmed
Revision history for this message
Martin Pool (mbp) wrote :

There's no rsync option which will preserve the x bit but not the other permissions.

The only solution I can think of at the moment is

  rsync --rsync-path='umask 002 && rsync'

though the contents obviously need to be user-specific.

Revision history for this message
John A Meinel (jameinel) wrote :

This seems to be a bzrtools bug. Do we have any plans to fix it for 0.9? It doesn't seem to merit a 'high' importance rating.

Revision history for this message
Robert Collins (lifeless) wrote :

Not a bzr bug; and not a push bug anymore either as its relegated to 'rpush' in bzrtools.

Changed in bzr:
status: Confirmed → Rejected
Revision history for this message
James Westby (james-w) wrote :

Moving to bzrtools as that provides rspush.

Thanks,

James

Changed in bzrtools (Ubuntu):
importance: Undecided → Low
status: New → Triaged
David Futcher (bobbo)
tags: added: patch-forwarded-upstream
Aaron Bentley (abentley)
Changed in bzrtools:
status: New → Won't Fix
Jelmer Vernooij (jelmer)
Changed in bzrtools (Ubuntu):
status: Triaged → Won't Fix
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.