Launchpad itself

Shouldn't be able to add duplicate bug watches

Bug #4594 reported by Matthew Paul Thomas
14
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Björn Tillenius

Bug Description

Being the doofus that I am, I just added a duplicate bug watch from Malone's bug 1084 to bugzilla.mozilla.org's bug 223132. I can't delete the watch (bug 3976), but Launchpad shouldn't have let me add the duplicate watch in the first place.

Revision history for this message
Brad Bollenbach (bradb) wrote :

Malone is the doofus here.

Revision history for this message
Christian Reis (kiko) wrote :

We should definitely avoid this, though doing so is not so easy because the remote bug isn't an integer. Is there a reason why it's not an integer, though? I think we were thinking of supporting SF.net bugs using their full URLs, but the reality is they do actually have a unique bug identifier!

Changed in malone:
assignee: bradb → bjornt
importance: Medium → High
Christian Reis (kiko)
Changed in malone:
importance: High → Critical
Revision history for this message
Björn Tillenius (bjornt) wrote :

Now that we have switched to using URLs for adding bug watches, it doesn't matter much that the remote bug isn't an integer. We still have a few places where you can edit the remote bug manually, but I don't think we have to care about matching 42 to #42 for now. In time we'll switch to using URLs everywhere for bug watches.

Changed in malone:
status: Confirmed → In Progress
Björn Tillenius (bjornt)
Changed in malone:
status: In Progress → Fix Committed
Revision history for this message
Björn Tillenius (bjornt) wrote :

This bug isn't really Critical.

Changed in malone:
importance: Critical → Medium
Revision history for this message
Christian Reis (kiko) wrote :

We now create new bug watches using URLs. They can still be changed to take integers and it's still possible to create dupes there, I think, but I've filed a follow-up bug 74428.

Changed in malone:
status: Fix Committed → Fix Released
Revision history for this message
Björn Tillenius (bjornt) wrote : Re: [Bug 4594] Re: Shouldn't be able to add duplicate bug watches

On Mon, Dec 04, 2006 at 08:43:11PM -0000, Christian Reis wrote:
> We now create new bug watches using URLs. They can still be changed to
> take integers and it's still possible to create dupes there, I think,
> but I've filed a follow-up bug 74428.

Where? There should be duplicate checking in every place we add or
create bug watches.

Revision history for this message
Christian Reis (kiko) wrote :

On Tue, Dec 05, 2006 at 06:23:35AM -0000, Björn Tillenius wrote:
> There should be duplicate checking in every place we add or
> create bug watches.

I just went and edited

    https://staging.launchpad.net/distros/ubuntu/+source/mozilla-thunderbird/+bug/1084

The first watch, which is:

    https://staging.launchpad.net/distros/ubuntu/+source/mozilla-thunderbird/+bug/1084/watches/57

I went and modified to be the same as

    https://staging.launchpad.net/distros/ubuntu/+source/mozilla-thunderbird/+bug/1084/watches/292

And it worked. You can see the results on the bug page -- but only while
staging hasn't resynced.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.