Can't encode without subtitles

Confirmed, reported upstream : https://sourceforge.net/tracker/?func=detail&aid=2888330&group_id=75595&atid=544485

Actually, this is a problem with mplayer. The upstream commit that fixes the issue is:

http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/2009-March/036924.html

I have put updated mplayer packages in my PPA that fix the ogmrip issue for me, could you please test them and report here if it worked for you? Thanks.

My PPA is here:

https://launchpad.net/~mdeslaur/+archive/ppa

Thanks Marc, it's working perfectly now :)

So, the encodes were OK? The subtitles weren't part of the video but rather being displayed by mplayer? And it is a bug in mplayer that was preventing me from turning the subtitles off? Doh! I deleted all the encodes ;-)

No, the encodes were bad. ogmrip uses mencoder, which is part of mplayer to encode the videos.

Thanks for the fix in the PPA. It's running fine for me.

@Mark
Do you plan to do a SRU for this ? This is quite critical for ogmrip.

Yes, I'll submit a SRU this week.

This bug was fixed in the package mplayer - 2:1.0~rc3+svn20090426-1ubuntu12

---------------
mplayer (2:1.0~rc3+svn20090426-1ubuntu12) lucid; urgency=low

  * debian/patches/41_fix_forcedsubsonly.patch: fix the forcedsubsonly
    option. This fixes a problem with ogmrip always encoding with
    subtitles. (LP: #458129).
  * debian/control: Change build-dep libxvidcore4-dev to libxvidcore-dev.
    (LP: #486169)
 -- Marc Deslauriers <email address hidden> Mon, 23 Nov 2009 20:11:33 -0500

SRU request:

Impact:
The svn snapshot of the mplayer package in Karmic does not honour the "forcedsubsonly" command line option. This affects the ogmrip package in that every video encoded with it will have subtitles, even when subtitles are not selected. This is a regression from Jaunty, and renders ogmrip unusable.

How the bug has been addressed:
The bug has been fixed by pulling in two commits from upstream mplayer that fix this issue. A package with the fixes was uploaded to my PPA, and tested by me and others.

Patch:
A debdiff is attached for review.

Instructions for reproduce:
- Install ogmrip
- Convert a DVD into a video file
- Watch the video file and notice the subtitles at the bottom

Regression potential:
I can't think of a reason why this could be a regression. If so, it's a simple fix to revert the patch.

Subscribing motu-sru for acking.

ACK from MOTU-SRU.

Accepted mplayer into karmic-proposed, the package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

I successfully tested the mplayer packages in -proposed.

- mplayer still plays videos
- ogmrip successfully rips a dvd without displaying subtitles
- ogmrip successfully rips a dvd when manually selecting subtitle track.

This bug was fixed in the package mplayer - 2:1.0~rc3+svn20090426-1ubuntu10.1

---------------
mplayer (2:1.0~rc3+svn20090426-1ubuntu10.1) karmic-proposed; urgency=low

  * debian/patches/41_fix_forcedsubsonly.patch: fix the forcedsubsonly
    option. This fixes a problem with ogmrip always encoding with
    subtitles. (LP: #458129).
 -- Marc Deslauriers <email address hidden> Tue, 24 Nov 2009 08:26:53 -0500