Launchpad itself

Refactor translation credits detection in POTMsgSet

Bug #456498 reported by Henning Eggers
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
Medium
Henning Eggers
Launchpad itself 3.1.10

Bug Description

The property POTMsgSet.is_translation_credit compares the msgid to several strings to determine if it is a credit string. This method is used by POFile.prepareTranslationCredits which also compares the msgid to the same strings to find out which type of translation credit the msgid is. This type detection should be handled by POTMsgSet and the actual strings to compare against should not appear twice in the source code.

Related branches

lp:~henninge/launchpad/bug-456498
Brad Crittenden (community): Approve (code)
Diff: 447 lines
4 files modified
lib/lp/translations/doc/potmsgset.txt (+53/-18)
lib/lp/translations/interfaces/potmsgset.py (+36/-1)
lib/lp/translations/model/pofile.py (+20/-21)
lib/lp/translations/model/potmsgset.py (+28/-16)
Henning Eggers (henninge)
Changed in rosetta:
status: New → In Progress
importance: Undecided → Medium
assignee: nobody → Henning Eggers (henninge)
milestone: none → 3.1.10
Revision history for this message
Ursula Junque (ursinha) wrote : A commit mentioned this bug

This bug was mentioned in devel r9749 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/revision/9749>

Changed in rosetta:
status: In Progress → Fix Committed
tags: added: qa-needstesting
Henning Eggers (henninge)
tags: added: qa-ok
removed: qa-needstesting
Данило Шеган (danilo)
Changed in rosetta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.